Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1131043003: Revert 2.5 CLs that relate to pulling Extension port management out of messaging.js. (Closed)

Created:
5 years, 7 months ago by not at google - send to devlin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert 2.5 CLs that relate to pulling Extension port management out of messaging.js. The first is 1be1629824f63c62466b44fc90d40101fa9d495a: "Clear the onMessage and onDisconnect listeners when their Extension Port is destroyed." which was a fix to the original patch. The second, original patch is 32b3a84be9aa4f70e83bd47c2a5cb32f05ad7f7e: "Move the Extension Port implementation out of messaging.js into its own file port.js." This is the key patch, which has caused no end of trouble. The goal was noble: to fix the myriad of bugs which messaging has due to being written in JS not C++. It appears that the moral of the story is: this is impossible, and the hole we've dug in over the last 5 years cannot be recovered from (without a complete rewrite, I suppose). The last .5 of a patch was one of the tests added in b9dca05429b19ad398d1dbf7496b44a94ba0f306 which will no longer pass. BUG=486715, 477323, 475536 R=rockot@chromium.org Committed: https://crrev.com/e9eaf5d68e674ff1ce760a6304266de3a0219787 Cr-Commit-Position: refs/heads/master@{#329571}

Patch Set 1 #

Patch Set 2 : revert test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -133 lines) Patch
M chrome/test/data/extensions/api_test/messaging/connect/test.js View 1 12 chunks +41 lines, -55 lines 0 comments Download
M extensions/extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/resources/messaging.js View 6 chunks +71 lines, -11 lines 0 comments Download
D extensions/renderer/resources/port.js View 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
not at google - send to devlin
5 years, 7 months ago (2015-05-12 18:15:11 UTC) #2
Ken Rockot(use gerrit already)
yikes. lgtm
5 years, 7 months ago (2015-05-12 22:21:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131043003/20001
5 years, 7 months ago (2015-05-13 01:11:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 02:30:14 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 02:31:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9eaf5d68e674ff1ce760a6304266de3a0219787
Cr-Commit-Position: refs/heads/master@{#329571}

Powered by Google App Engine
This is Rietveld 408576698