Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1131023004: clang/win: Fix style plugin warnings in debug builds. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
danakj, vmpstr, davidben
CC:
chromium-reviews, cc-bugs_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix style plugin warnings in component debug builds. std::iterators are classes in debug builds in MSVC, so outline a destructor in a class that has many iterator members in net/. Make the copy constructor of TilingSetRasterQueueAll private. Without this, an implicit copy constructor is generated with the ms abi because the class is marked dllexport, and the implicit copy constructor needs a copy constructor for TilingIterator which the plugin also wants to have out-of-line. Making the outer dllexported class not copyable should fix this. BUG=467287, 483986 Committed: https://crrev.com/ba38d5369f28e3222904818a3b59b2f908e29163 Cr-Commit-Position: refs/heads/master@{#329435}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : ccdis #

Patch Set 4 : netdis #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/resources/tiling_set_raster_queue_all.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_auth_challenge_tokenizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_auth_challenge_tokenizer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
davidben: net/ vmpstr: cc/
5 years, 7 months ago (2015-05-12 02:33:14 UTC) #2
davidben
net lgtm
5 years, 7 months ago (2015-05-12 16:44:43 UTC) #3
danakj
LGTM
5 years, 7 months ago (2015-05-12 17:48:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131023004/100001
5 years, 7 months ago (2015-05-12 17:50:01 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-12 17:54:11 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 17:55:31 UTC) #9
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ba38d5369f28e3222904818a3b59b2f908e29163
Cr-Commit-Position: refs/heads/master@{#329435}

Powered by Google App Engine
This is Rietveld 408576698