Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 113100: DevTools: Activate inspector window on break / exception. (Closed)

Created:
11 years, 7 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

DevTools: Activate inspector window on break / exception. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15632

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -21 lines) Patch
M chrome/renderer/devtools_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/devtools_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/devtools/js/debugger_agent.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webdevtoolsclient_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webdevtoolsclient_impl.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M webkit/glue/webdevtoolsclient_impl.cc View 1 2 chunks +33 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
11 years, 7 months ago (2009-05-07 15:12:18 UTC) #1
yurys
http://codereview.chromium.org/113100/diff/1/3 File webkit/glue/devtools/js/debugger_agent.js (right): http://codereview.chromium.org/113100/diff/1/3#newcode368 Line 368: DevToolsHost.activateWindow(); you can place it into 'backtrace' response ...
11 years, 7 months ago (2009-05-08 09:54:19 UTC) #2
pfeldman
http://codereview.chromium.org/113100/diff/1/3 File webkit/glue/devtools/js/debugger_agent.js (right): http://codereview.chromium.org/113100/diff/1/3#newcode368 Line 368: DevToolsHost.activateWindow(); On 2009/05/08 09:54:19, Yury Semikhatsky wrote: > ...
11 years, 7 months ago (2009-05-08 10:11:32 UTC) #3
yurys
11 years, 7 months ago (2009-05-08 10:16:37 UTC) #4
LGTM.
On 2009/05/08 10:11:32, pfeldman wrote:
> http://codereview.chromium.org/113100/diff/1/3
> File webkit/glue/devtools/js/debugger_agent.js (right):
> 
> http://codereview.chromium.org/113100/diff/1/3#newcode368
> Line 368: DevToolsHost.activateWindow();
> On 2009/05/08 09:54:19, Yury Semikhatsky wrote:
> > you can place it into 'backtrace' response handler so that the window is
> > activated after the UI update
> 
> Done.
> 
> http://codereview.chromium.org/113100/diff/1/5
> File webkit/glue/webdevtoolsclient_impl.cc (right):
> 
> http://codereview.chromium.org/113100/diff/1/5#newcode255
> Line 255: Page* page = V8Proxy::retrieveActiveFrame()->page();
> On 2009/05/08 09:54:19, Yury Semikhatsky wrote:
> > There may be no active frame. Also can you bind a method of the
> > WebDevToolsClientImpl instance to avoid client lookup?
> > 
> 
> There is frame since the call is from our window.
> I don't know if I can bind to method here. Any hints?

Powered by Google App Engine
This is Rietveld 408576698