DevTools: Activate inspector window on break / exception.

DevTools: Activate inspector window on break / exception.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15632

[yurys, 2009-05-08 09:54:19]

http://codereview.chromium.org/113100/diff/1/3
File webkit/glue/devtools/js/debugger_agent.js (right):

http://codereview.chromium.org/113100/diff/1/3#newcode368
Line 368: DevToolsHost.activateWindow();
you can place it into 'backtrace' response handler so that the window is
activated after the UI update

http://codereview.chromium.org/113100/diff/1/5
File webkit/glue/webdevtoolsclient_impl.cc (right):

http://codereview.chromium.org/113100/diff/1/5#newcode255
Line 255: Page* page = V8Proxy::retrieveActiveFrame()->page();
There may be no active frame. Also can you bind a method of the
WebDevToolsClientImpl instance to avoid client lookup?

[pfeldman, 2009-05-08 10:11:32]

http://codereview.chromium.org/113100/diff/1/3
File webkit/glue/devtools/js/debugger_agent.js (right):

http://codereview.chromium.org/113100/diff/1/3#newcode368
Line 368: DevToolsHost.activateWindow();
On 2009/05/08 09:54:19, Yury Semikhatsky wrote:
> you can place it into 'backtrace' response handler so that the window is
> activated after the UI update

Done.

http://codereview.chromium.org/113100/diff/1/5
File webkit/glue/webdevtoolsclient_impl.cc (right):

http://codereview.chromium.org/113100/diff/1/5#newcode255
Line 255: Page* page = V8Proxy::retrieveActiveFrame()->page();
On 2009/05/08 09:54:19, Yury Semikhatsky wrote:
> There may be no active frame. Also can you bind a method of the
> WebDevToolsClientImpl instance to avoid client lookup?
> 

There is frame since the call is from our window.
I don't know if I can bind to method here. Any hints?

[yurys, 2009-05-08 10:16:37]

LGTM.
On 2009/05/08 10:11:32, pfeldman wrote:
> http://codereview.chromium.org/113100/diff/1/3
> File webkit/glue/devtools/js/debugger_agent.js (right):
> 
> http://codereview.chromium.org/113100/diff/1/3#newcode368
> Line 368: DevToolsHost.activateWindow();
> On 2009/05/08 09:54:19, Yury Semikhatsky wrote:
> > you can place it into 'backtrace' response handler so that the window is
> > activated after the UI update
> 
> Done.
> 
> http://codereview.chromium.org/113100/diff/1/5
> File webkit/glue/webdevtoolsclient_impl.cc (right):
> 
> http://codereview.chromium.org/113100/diff/1/5#newcode255
> Line 255: Page* page = V8Proxy::retrieveActiveFrame()->page();
> On 2009/05/08 09:54:19, Yury Semikhatsky wrote:
> > There may be no active frame. Also can you bind a method of the
> > WebDevToolsClientImpl instance to avoid client lookup?
> > 
> 
> There is frame since the call is from our window.
> I don't know if I can bind to method here. Any hints?