Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: BUILD.gn

Issue 1130993003: Reland: Make V8 extras a separate type of native (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@fix-snapshot
Patch Set: Fix js2c.py's dummy files Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 0908150c3ee67b7675df591a8d325bd5a2f7a2a6..3f5c0cd092822a8f86a084da431c53c6c68fe718 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -296,6 +296,36 @@ action("js2c_experimental") {
}
}
+action("js2c_extras") {
+ visibility = [ ":*" ] # Only targets in this file can depend on this.
+
+ script = "tools/js2c.py"
+
+ # The script depends on this other script, this rule causes a rebuild if it
+ # changes.
+ inputs = [ "tools/jsmin.py" ]
+
+ sources = v8_extra_library_files
+
+ outputs = [
+ "$target_gen_dir/extras-libraries.cc",
+ ]
+
+ args = [
+ rebase_path("$target_gen_dir/extras-libraries.cc",
+ root_build_dir),
+ "EXTRAS",
+ ] + rebase_path(sources, root_build_dir)
+
+ if (v8_use_external_startup_data) {
+ outputs += [ "$target_gen_dir/libraries_extras.bin" ]
+ args += [
+ "--startup_blob",
+ rebase_path("$target_gen_dir/libraries_extras.bin", root_build_dir),
+ ]
+ }
+}
+
action("d8_js2c") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
@@ -321,11 +351,13 @@ if (v8_use_external_startup_data) {
deps = [
":js2c",
":js2c_experimental",
+ ":js2c_extras",
]
sources = [
"$target_gen_dir/libraries.bin",
"$target_gen_dir/libraries_experimental.bin",
+ "$target_gen_dir/libraries_extras.bin",
]
outputs = [
@@ -410,12 +442,14 @@ source_set("v8_nosnapshot") {
deps = [
":js2c",
":js2c_experimental",
+ ":js2c_extras",
":v8_base",
]
sources = [
"$target_gen_dir/libraries.cc",
"$target_gen_dir/experimental-libraries.cc",
+ "$target_gen_dir/extras-libraries.cc",
"src/snapshot/snapshot-empty.cc",
]
@@ -439,6 +473,7 @@ source_set("v8_snapshot") {
deps = [
":js2c",
":js2c_experimental",
+ ":js2c_extras",
":run_mksnapshot",
":v8_base",
]
@@ -446,6 +481,7 @@ source_set("v8_snapshot") {
sources = [
"$target_gen_dir/libraries.cc",
"$target_gen_dir/experimental-libraries.cc",
+ "$target_gen_dir/extras-libraries.cc",
"$target_gen_dir/snapshot.cc",
]
@@ -465,6 +501,7 @@ if (v8_use_external_startup_data) {
deps = [
":js2c",
":js2c_experimental",
+ ":js2c_extras",
":run_mksnapshot",
":v8_base",
":natives_blob",
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698