Reland: Make V8 extras a separate type of native

src/snapshot/natives-external.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/snapshot/natives.h"
 
 #include "src/base/logging.h"
 #include "src/list.h"
 #include "src/list-inl.h"
 #include "src/snapshot/snapshot-source-sink.h"
@@ skipping 141 matching lines @@
 
 /**
  * Read the Natives blob, as previously set by SetNativesFromFile.
  */
 void ReadNatives() {
   if (natives_blob_ && NativesHolder<CORE>::empty()) {
     SnapshotByteSource bytes(natives_blob_->data, natives_blob_->raw_size);
     NativesHolder<CORE>::set(NativesStore::MakeFromScriptsSource(&bytes));
     NativesHolder<EXPERIMENTAL>::set(
         NativesStore::MakeFromScriptsSource(&bytes));
+    NativesHolder<EXTRAS>::set(NativesStore::MakeFromScriptsSource(&bytes));
     DCHECK(!bytes.HasMore());
   }
 }
 
 
 /**
  * Set the Natives (library sources) blob, as generated by js2c + the build
  * system.
  */
 void SetNativesFromFile(StartupData* natives_blob) {
   DCHECK(!natives_blob_);
   DCHECK(natives_blob);
   DCHECK(natives_blob->data);
   DCHECK(natives_blob->raw_size > 0);
 
   natives_blob_ = natives_blob;
   ReadNatives();
 }
 
 
 /**
  * Release memory allocated by SetNativesFromFile.
  */
 void DisposeNatives() {
   NativesHolder<CORE>::Dispose();
   NativesHolder<EXPERIMENTAL>::Dispose();
+  NativesHolder<EXTRAS>::Dispose();
 }
 
 
 // Implement NativesCollection<T> bsaed on NativesHolder + NativesStore.
 //
 // (The callers expect a purely static interface, since this is how the
 //  natives are usually compiled in. Since we implement them based on
 //  runtime content, we have to implement this indirection to offer
 //  a static interface.)
 template<NativeType type>
@@ skipping 24 matching lines @@
 template <NativeType type>
 Vector<const char> NativesCollection<type>::GetScriptsSource() {
   return NativesHolder<type>::get()->GetScriptsSource();
 }
 
 
 // The compiler can't 'see' all uses of the static methods and hence
 // my choice to elide them. This we'll explicitly instantiate these.
 template class NativesCollection<CORE>;
 template class NativesCollection<EXPERIMENTAL>;
+template class NativesCollection<EXTRAS>;
 
 }  // namespace v8::internal
 }  // namespace v8