[chrome/browser/media_galleries/fileapi] Use ThreadTaskRunnerHandle instead of MessageLoopProxy

Replace deprecated MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/media_galleries/fileapi module.

BUG=391045
Committed: https://crrev.com/5fa4379ae55e5a372296b57cb68c7f63a98e92d6
Cr-Commit-Position: refs/heads/master@{#328936}

[Pranay, 2015-05-07 13:26:37]

pranay.kumar@samsung.com changed reviewers:
+ kinuko@chromium.org

[Pranay, 2015-05-07 13:26:38]

PTAL

Thanks!

[kinuko, 2015-05-07 14:24:20]

kinuko@chromium.org changed reviewers:
+ thestig@chromium.org

[kinuko, 2015-05-07 14:27:16]

LGTM

Adding +thestig@ as the real owner of media_galleries in case he may have
comments.

[Pranay, 2015-05-07 15:08:27]

Sure :)
Thanks for the review

-Pranay

[Lei Zhang, 2015-05-07 20:02:50]

https://codereview.chromium.org/1130993002/diff/1/chrome/browser/media_galler...
File chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc
(right):

https://codereview.chromium.org/1130993002/diff/1/chrome/browser/media_galler...
chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc:15: #include
"base/single_thread_task_runner.h"
In the files where you do not call
base::ThreadTaskRunnerHandle::Get())->Method(), this isn't needed.

[Lei Zhang, 2015-05-07 20:04:27]

BTW, for the commit message, you can just write "Replace deprecated
MessageLoopProxy usage with ThreadTaskRunnerHandle in ..." and skip the
"MessageLoopProxy is deprecated...".

[Pranay, 2015-05-07 20:39:42]

Hi Lei,

Thanks for the review :) Sure, but I have one doubt (in reference to another
CL), as per Ryan's comment in following at line 117
"https://codereview.chromium.org/1121213002/diff2/1:20001/chrome/browser/net/quota_policy_channel_id_store_unittest.cc"
he mentioned as => single_thread_task_runner.h would be required so that
TTRH::Get() call (which returns a
scoped_refptr<SingleThreadTaskRunner>) can be convertible to a
SequencedTaskRunner.  

In=> chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc:212 ,
FileSystemContext is being referred which expects first two arguments as
base::SingleThreadTaskRunner* and base::SequencedTaskRunner* which i have tried
to change by TTRH::Get(), so what should be done here? 

Can you clarify my confusion as since i might be adding some more patches
related to the same bug, it would be highly beneficial

Thanks!
-Pranay

[Pranay, 2015-05-07 20:43:11]

Also updated commit message & will keep the same short message from now on :)

[Lei Zhang, 2015-05-07 20:53:21]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-05-07 20:53:21]

lgtm

[commit-bot: I haz the power, 2015-05-07 20:54:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130993002/1

[commit-bot: I haz the power, 2015-05-07 21:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 21:20:08]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Pranay, 2015-05-08 05:13:24]

Hi Lei,
Sorry there was a issue w.r.t. casting for unittest files ( 3 files in this
patch). Fixed & updated the same. PTAL

Thanks

[Pranay, 2015-05-08 05:37:53]

The CQ bit was checked by pranay.kumar@samsung.com

[Pranay, 2015-05-08 05:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1130993002/#ps20001
(title: "Fixed Build Break")

[Pranay, 2015-05-08 05:38:21]

The CQ bit was unchecked by pranay.kumar@samsung.com

[Pranay, 2015-05-08 05:39:25]

The CQ bit was checked by pranay.kumar@samsung.com

[commit-bot: I haz the power, 2015-05-08 05:39:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130993002/20001

[Pranay, 2015-05-08 05:40:00]

The CQ bit was unchecked by pranay.kumar@samsung.com

[kinuko, 2015-05-08 05:40:49]

still lgtm

[Pranay, 2015-05-08 05:41:38]

Thanks!! :)

-Pranay

[Pranay, 2015-05-08 05:41:44]

The CQ bit was checked by pranay.kumar@samsung.com

[commit-bot: I haz the power, 2015-05-08 05:42:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130993002/20001

[commit-bot: I haz the power, 2015-05-08 06:52:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-08 06:53:29]

Patchset 2 (id:??) landed as
https://crrev.com/5fa4379ae55e5a372296b57cb68c7f63a98e92d6
Cr-Commit-Position: refs/heads/master@{#328936}