Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1130953002: Revert of Fixit: Factor out common base::Time* math operator overloads. (Closed)

Created:
5 years, 7 months ago by Kunihiko Sakamoto
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, miu
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixit: Factor out common base::Time* math operator overloads. (patchset #2 id:40001 of https://codereview.chromium.org/1122443004/) Reason for revert: Broke iOS build. http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/5621/steps/compile/logs/stdio Original issue's description: > Fixit: Factor out common base::Time* math operator overloads. > > This is part 1 of a 2-part change to fork base::TimeTicks into three > type-checked time classes (TimeTicks + ThreadTicks + TraceTicks). The > forking of TimeTicks will ensure values from different clocks are not > erroneously being mixed together when doing time math. > > In this change, the identical comparison and math operator overloads > found in base::Time and base::TimeTicks are being factored-out into a > templated base class. In a following change, this base class will also > be used to de-dupe this common functionality in the two new time > classes. > > BUG=467417 > > Committed: https://crrev.com/7ca717095b4758cb76e53e904b775852e46d646d > Cr-Commit-Position: refs/heads/master@{#328696} TBR=thestig@chromium.org,miu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467417 Committed: https://crrev.com/a365825583412c355a449274bec70e41e992ffd7 Cr-Commit-Position: refs/heads/master@{#328706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -173 lines) Patch
M base/time/time.h View 17 chunks +208 lines, -160 lines 0 comments Download
M base/time/time.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M base/time/time_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kunihiko Sakamoto
Created Revert of Fixit: Factor out common base::Time* math operator overloads.
5 years, 7 months ago (2015-05-07 04:32:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130953002/1
5 years, 7 months ago (2015-05-07 04:34:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 04:35:31 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a365825583412c355a449274bec70e41e992ffd7 Cr-Commit-Position: refs/heads/master@{#328706}
5 years, 7 months ago (2015-05-07 04:36:37 UTC) #4
miu
5 years, 7 months ago (2015-05-07 04:56:29 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1128273004/ by miu@chromium.org.

The reason for reverting is: DO NOT COMMIT.

Powered by Google App Engine
This is Rietveld 408576698