Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130933005: Remove code for showing cloud print page on plugging-in a printer (Closed)

Created:
5 years, 7 months ago by tbarzic
Modified:
5 years, 7 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code for showing cloud print page on plugging-in a printer chrome.printerProvider API's going to stable, so this is not needed anymore. BUG=439448, 488661 Committed: https://crrev.com/8258073a4cbe27d36d972db125757969b0ec669b Cr-Commit-Position: refs/heads/master@{#330437}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : update histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -129 lines) Patch
M chrome/browser/chromeos/dbus/printer_service_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/printer_service_provider.cc View 1 2 10 chunks +21 lines, -84 lines 0 comments Download
M chrome/browser/chromeos/dbus/printer_service_provider_unittest.cc View 3 chunks +1 line, -40 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
tbarzic
achuith for owner approval
5 years, 7 months ago (2015-05-15 21:38:48 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/1130933005/diff/20001/chrome/browser/chromeos/dbus/printer_service_provider.cc File chrome/browser/chromeos/dbus/printer_service_provider.cc (left): https://codereview.chromium.org/1130933005/diff/20001/chrome/browser/chromeos/dbus/printer_service_provider.cc#oldcode129 chrome/browser/chromeos/dbus/printer_service_provider.cc:129: UMA_HISTOGRAM_ENUMERATION("PrinterService.PrinterServiceEvent", would you like to move PAGE_DISPLAYED, even ...
5 years, 7 months ago (2015-05-15 22:00:18 UTC) #3
tbarzic
+isherman for histograms https://codereview.chromium.org/1130933005/diff/20001/chrome/browser/chromeos/dbus/printer_service_provider.cc File chrome/browser/chromeos/dbus/printer_service_provider.cc (left): https://codereview.chromium.org/1130933005/diff/20001/chrome/browser/chromeos/dbus/printer_service_provider.cc#oldcode129 chrome/browser/chromeos/dbus/printer_service_provider.cc:129: UMA_HISTOGRAM_ENUMERATION("PrinterService.PrinterServiceEvent", On 2015/05/15 22:00:18, Vitaly Buka ...
5 years, 7 months ago (2015-05-15 22:36:55 UTC) #5
achuithb
owner rubberstamp lgtm
5 years, 7 months ago (2015-05-15 22:37:32 UTC) #6
Ilya Sherman
lgtm
5 years, 7 months ago (2015-05-16 02:02:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130933005/40001
5 years, 7 months ago (2015-05-18 17:24:20 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-18 22:04:17 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:44:28 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8258073a4cbe27d36d972db125757969b0ec669b
Cr-Commit-Position: refs/heads/master@{#330437}

Powered by Google App Engine
This is Rietveld 408576698