Issue 113093004: [PDF] Fix font width generation when glyph 0 is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113093004: [PDF] Fix font width generation when glyph 0 is used. (Closed)

Created:
7 years ago by vandebo (ex-Chrome)

Modified:
7 years ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

[PDF] Fix font width generation when glyph 0 is used. Using glyph 0 caused gid 0 to be in the subset list twice, which violated an assumption in the code. Added an assert for the assumption and updated the code to not insert gid 0 into the subset list twice. BUG=skia:1889 Committed: http://code.google.com/p/skia/source/detail?r=12632

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/core/SkAdvancedTypefaceMetrics.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/pdf/SkPDFFont.cpp	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/113093004/1

7 years ago (2013-12-11 23:44:18 UTC) #3

Message was sent while issue was closed.

Change committed as 12632

Expand Messages | Collapse Messages