Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1130913005: Revert of X87: Resolve references to "this" the same way as normal variables (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of X87: Resolve references to "this" the same way as normal variables Reason for revert: original commit was reverted. This reverts commit c3529ce50158546e2f2c25ee888e7e0170a488f1. original issues's description: > X87: Resolve references to "this" the same way as normal variables > > port 06a792b7cc2db33ffce7244c044a9c05afbb6116 (r28263). > > original commit message: > > Make the parser handle references to "this" as unresolved variables, so the > same logic as for the rest of function parameters is used for the receiver. > Minor additions to the code generation handle copying the receiver to the > context, along with the rest of the function parameters. > > Based on work by Adrian Perez de Castro <aperez@igalia.com>; BUG= Committed: https://crrev.com/93662ec2355995ba7a0c1f0c4828f93db2f3adaa Cr-Commit-Position: refs/heads/master@{#28307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 7 months ago (2015-05-08 02:54:24 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-08 03:35:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130913005/1
5 years, 7 months ago (2015-05-08 03:35:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 03:57:31 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 03:57:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93662ec2355995ba7a0c1f0c4828f93db2f3adaa
Cr-Commit-Position: refs/heads/master@{#28307}

Powered by Google App Engine
This is Rietveld 408576698