Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1130903006: cros: Fix DriveAppProvider racing during initialization. (Closed)

Created:
5 years, 7 months ago by xiyuan
Modified:
5 years, 7 months ago
Reviewers:
benwells, zel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix DriveAppProvider racing during initialization. Sync changes could trigger UpdateDriveApps before DriveAppRegistry is populated with data. An empty list from DriveAppRegistry causes all Drive apps be uninstalled. And some Drive apps would cause Gaia cookies to be lost. BUG=449816 TEST=DriveAppProviderTest.UpdateAfterDriveAppRegistryUpdate Committed: https://crrev.com/360221c5f9fd70a6bc9722bc3638e4d62be2cc43 Cr-Commit-Position: refs/heads/master@{#329561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M chrome/browser/apps/drive/drive_app_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_provider.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_provider_browsertest.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xiyuan
5 years, 7 months ago (2015-05-12 22:51:58 UTC) #2
zel
lgtm
5 years, 7 months ago (2015-05-12 23:48:42 UTC) #4
benwells
lgtm
5 years, 7 months ago (2015-05-13 01:03:16 UTC) #5
xiyuan
Thank you all for the quick review.
5 years, 7 months ago (2015-05-13 01:11:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130903006/1
5 years, 7 months ago (2015-05-13 01:13:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 01:50:09 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 01:52:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/360221c5f9fd70a6bc9722bc3638e4d62be2cc43
Cr-Commit-Position: refs/heads/master@{#329561}

Powered by Google App Engine
This is Rietveld 408576698