media/audio/win/waveout_output_win.cc - Issue 11309015: Increase Windows XP hardware buffer size to 4096.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/win/waveout_output_win.cc

Issue 11309015: Increase Windows XP hardware buffer size to 4096. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/win/waveout_output_win.cc

diff --git a/media/audio/win/waveout_output_win.cc b/media/audio/win/waveout_output_win.cc

index 12b4251d5ef671b11a2203bc2ee903e8f51792d9..025b1aeb41d54e7d1f0f696d83be4e00bb96ca54 100644

--- a/media/audio/win/waveout_output_win.cc

+++ b/media/audio/win/waveout_output_win.cc

@@ -284,7 +284,9 @@ void PCMWaveOutAudioOutputStream::Stop() {

GetBuffer(ix)->dwFlags = WHDR_PREPARED;

}

- // Don't use callback after Stop().

+ // Don't use callback after Stop(). Wait for lock to ensure all outstanding

+ // callbacks have completed.

+ base::AutoLock auto_lock(lock_);

Chris Rogers 2012/11/15 22:49:30 maybe this auto_lock should be moved up to just ab

DaleCurtis 2012/11/15 22:58:23 Done.

callback_ = NULL;

state_ = PCMA_READY;

« no previous file with comments | « media/audio/audio_util.cc ('k') | media/base/media_switches.h » ('j') | no next file with comments »