Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1130883003: Enable GrAAConvexTessellator in GrAAConvexPathRenderer (Closed)

Created:
5 years, 7 months ago by robertphillips
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable GrAAConvexTessellator in GrAAConvexPathRenderer This CL plumbs the GrAAConvexTessellator into the GrAAConvexPathRenderer but disables in Chrome & Android. Committed: https://skia.googlesource.com/skia/+/e16dfdbeadcb659e2ff4c56669fc08ee69e3f18f

Patch Set 1 #

Patch Set 2 : Turn off in Chrome & Android #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -0 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 5 chunks +143 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 7 months ago (2015-05-07 18:57:26 UTC) #2
joshualitt
On 2015/05/07 18:57:26, robertphillips wrote: lgtm
5 years, 7 months ago (2015-05-07 19:09:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130883003/40001
5 years, 7 months ago (2015-05-07 19:12:16 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-07 19:18:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130883003/40001
5 years, 7 months ago (2015-05-08 11:46:37 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 11:46:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e16dfdbeadcb659e2ff4c56669fc08ee69e3f18f

Powered by Google App Engine
This is Rietveld 408576698