Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1130873002: Enable //services/files/c:apptests on Android now that we have the C++11 library. (Closed)

Created:
5 years, 7 months ago by viettrungluu
Modified:
5 years, 7 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Enable //services/files/c:apptests on Android now that we have the C++11 library. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d5de98ee9fbb056b82e56c812e56cdc4edc55603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -91 lines) Patch
M mojo/BUILD.gn View 2 chunks +2 lines, -5 lines 0 comments Download
M mojo/tools/data/apptests View 3 chunks +4 lines, -5 lines 0 comments Download
M services/files/c/BUILD.gn View 1 chunk +68 lines, -72 lines 0 comments Download
M services/files/c/lib/util.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M services/files/c/mojio_sys_stat.h View 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 7 months ago (2015-05-06 20:13:56 UTC) #1
jamesr
lgtm
5 years, 7 months ago (2015-05-07 23:35:59 UTC) #2
viettrungluu
5 years, 7 months ago (2015-05-08 21:07:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5de98ee9fbb056b82e56c812e56cdc4edc55603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698