Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1130863002: Remove unused data reduction proxy prefs from direct settings API. (Closed)

Created:
5 years, 7 months ago by Not at Google. Contact bengr
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused data reduction proxy prefs from direct settings API. Also remove unused data reduction pref from preferences API. BUG=442494 Committed: https://crrev.com/e8280f3afe7cff09bb5b23c959928ccbdc16da25 Cr-Commit-Position: refs/heads/master@{#329263}

Patch Set 1 #

Patch Set 2 : Sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/data_reduction_proxy.json View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/preferences_private.json View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Not at Google. Contact bengr
kalman: chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc chrome/browser/extensions/api/preference/preference_api.cc chrome/common/extensions/api/data_reduction_proxy.json chrome/common/extensions/api/preferences_private.json
5 years, 7 months ago (2015-05-06 18:43:45 UTC) #2
Not at Google. Contact bengr
Ping. Ben, Can you please take a look?
5 years, 7 months ago (2015-05-11 16:18:05 UTC) #3
not at google - send to devlin
lgtm, sorry I missed this.
5 years, 7 months ago (2015-05-11 16:23:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130863002/20001
5 years, 7 months ago (2015-05-11 22:02:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 22:54:03 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 22:55:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8280f3afe7cff09bb5b23c959928ccbdc16da25
Cr-Commit-Position: refs/heads/master@{#329263}

Powered by Google App Engine
This is Rietveld 408576698