Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1130853007: Revert "X87: Resolve references to "this" the same way as normal variables" (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "X87: Resolve references to "this" the same way as normal variables" This reverts commit 6eea252463648d81cf3ae128e6f0d5f815a108bb. revert reason: original patch is reverted. BUG= Committed: https://crrev.com/19a421c694d2aaa6314dd19d25b55de4507bb56d Cr-Commit-Position: refs/heads/master@{#28401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 7 months ago (2015-05-14 08:56:19 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-14 08:57:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130853007/1
5 years, 7 months ago (2015-05-14 08:58:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 09:23:03 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 09:23:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19a421c694d2aaa6314dd19d25b55de4507bb56d
Cr-Commit-Position: refs/heads/master@{#28401}

Powered by Google App Engine
This is Rietveld 408576698