Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/renderer/external_extension.cc

Issue 113085: Split V8Proxy::retrieveActiveFrame() into two methods. (Closed)
Patch Set: Darin feedback Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/external_extension.h" 5 #include "chrome/renderer/external_extension.h"
6 #include "chrome/renderer/render_view.h" 6 #include "chrome/renderer/render_view.h"
7 #include "webkit/glue/webframe.h" 7 #include "webkit/glue/webframe.h"
8 8
9 namespace extensions_v8 { 9 namespace extensions_v8 {
10 10
(...skipping 17 matching lines...) Expand all
28 if (name->Equals(v8::String::New("NativeAddSearchProvider"))) { 28 if (name->Equals(v8::String::New("NativeAddSearchProvider"))) {
29 return v8::FunctionTemplate::New(AddSearchProvider); 29 return v8::FunctionTemplate::New(AddSearchProvider);
30 } 30 }
31 return v8::Handle<v8::FunctionTemplate>(); 31 return v8::Handle<v8::FunctionTemplate>();
32 } 32 }
33 33
34 static v8::Handle<v8::Value> AddSearchProvider(const v8::Arguments& args) { 34 static v8::Handle<v8::Value> AddSearchProvider(const v8::Arguments& args) {
35 if (!args.Length()) 35 if (!args.Length())
36 return v8::Undefined(); 36 return v8::Undefined();
37 37
38 WebFrame* webframe = WebFrame::RetrieveActiveFrame(); 38 WebFrame* webframe = WebFrame::RetrieveFrameForEnteredContext();
39 DCHECK(webframe) << "There should be an active frame since we just got " 39 DCHECK(webframe) << "There should be an active frame since we just got "
40 "a native function called."; 40 "a native function called.";
41 if (!webframe) return v8::Undefined(); 41 if (!webframe) return v8::Undefined();
42 42
43 WebView* webview = webframe->GetView(); 43 WebView* webview = webframe->GetView();
44 if (!webview) return v8::Undefined(); // can happen during closing 44 if (!webview) return v8::Undefined(); // can happen during closing
45 45
46 RenderView* renderview = static_cast<RenderView*>(webview->GetDelegate()); 46 RenderView* renderview = static_cast<RenderView*>(webview->GetDelegate());
47 if (!renderview) return v8::Undefined(); 47 if (!renderview) return v8::Undefined();
48 48
49 std::string name = std::string(*v8::String::Utf8Value(args[0])); 49 std::string name = std::string(*v8::String::Utf8Value(args[0]));
50 if (!name.length()) return v8::Undefined();; 50 if (!name.length()) return v8::Undefined();;
51 51
52 renderview->AddSearchProvider(name); 52 renderview->AddSearchProvider(name);
53 return v8::Undefined(); 53 return v8::Undefined();
54 } 54 }
55 }; 55 };
56 56
57 v8::Extension* ExternalExtension::Get() { 57 v8::Extension* ExternalExtension::Get() {
58 return new ExternalExtensionWrapper(); 58 return new ExternalExtensionWrapper();
59 } 59 }
60 60
61 } // namespace extensions_v8 61 } // namespace extensions_v8
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/renderer_extension_bindings.cc ('k') | chrome/renderer/loadtimes_extension_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698