Chromium Code Reviews Chromium Code Reviews
Issue 1130843004:
[CSS Grid Layout] New alignment related repaint layout tests. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/repaint/align-content-position-change-grid.html |
| diff --git a/LayoutTests/fast/repaint/align-content-change.html b/LayoutTests/fast/repaint/align-content-position-change-grid.html |
| similarity index 61% |
| copy from LayoutTests/fast/repaint/align-content-change.html |
| copy to LayoutTests/fast/repaint/align-content-position-change-grid.html |
| index e96b5f72800e326c1c279dae5be73626d93f1a7b..1e64c39cf3f488b77ce153469261562e07d4235e 100644 |
| --- a/LayoutTests/fast/repaint/align-content-change.html |
| +++ b/LayoutTests/fast/repaint/align-content-position-change-grid.html |
| @@ -1,8 +1,7 @@ |
| -<!DOCTYPE HTML> |
|
Julien - ping for review
2015/05/19 17:59:17
Doctype removed?
jfernandez
2015/05/20 20:11:34
Mistake, got it back.
|
| <script src="resources/text-based-repaint.js"></script> |
| <script> |
| function repaintTest() { |
| - document.getElementById('container').style.alignContent = 'stretch'; |
| + document.getElementById('container').style.alignContent = 'end'; |
| } |
| onload = runRepaintTest; |
| </script> |
| @@ -11,20 +10,20 @@ body { |
| margin: 0; |
| } |
| #container { |
| - display: flex; |
| - align-content: space-around; |
| - flex-flow: row wrap; |
| + display: grid; |
| + grid-auto-columns: 200px; |
| + grid-auto-rows: auto; |
| + grid-auto-flow: row; |
| + align-content: start; |
| width: 200px; |
| height: 300px; |
| background-color: red; |
| } |
| .item { |
| background-color: green; |
| - border: solid thin blue; |
| - width: 200px; |
| } |
| </style> |
| -<p style="height: 20px">Tests invalidation on align-content style change. Passes if there is no red.</p> |
| +<p style="height: 20px">Tests invalidation on align-content style change (position). Passes if the red half is on the top.</p> |
|
Julien - ping for review
2015/05/19 17:59:17
Red should mark failure, we should change the cond
jfernandez
2015/05/20 20:11:34
Done.
|
| <div id="container"> |
| <div class="item"> |
| <div style="height: 50px"></div> |
| @@ -32,4 +31,7 @@ body { |
| <div class="item"> |
| <div style="height: 50px"></div> |
| </div> |
| + <div class="item"> |
| + <div style="height: 50px"></div> |
| + </div> |
| </div> |
