Chromium Code Reviews Chromium Code Reviews
Issue 1130843004:
[CSS Grid Layout] New alignment related repaint layout tests. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <script src="resources/text-based-repaint.js"></script> | 2 <script src="resources/text-based-repaint.js"></script> |
| 3 <script> | 3 <script> |
| 4 function repaintTest() { | 4 function repaintTest() { |
| 5 document.getElementsByClassName('item1')[0].style.justifySelf = 'end safe'; | 5 document.getElementsByClassName('item1')[0].style.justifySelf = 'end safe'; |
| 6 document.getElementsByClassName('item2')[0].style.justifySelf = 'end safe'; | |
| 6 } | 7 } |
| 7 onload = runRepaintTest; | 8 onload = runRepaintTest; |
| 8 </script> | 9 </script> |
| 9 <style> | 10 <style> |
| 10 body { | 11 body { |
| 11 margin: 0; | 12 margin: 0; |
| 12 } | 13 } |
| 13 #container { | 14 #container { |
| 14 display: grid; | 15 display: grid; |
| 15 grid: 100px 100px / 150px 150px; | 16 grid: 100px 100px / 300px; |
|
Julien - ping for review
2015/05/19 17:59:18
Ditto.
jfernandez
2015/05/20 20:11:34
It does matter actually, as it was commented befor
| |
| 16 justify-items: end true; | |
| 17 width: 200px; | 17 width: 200px; |
| 18 height: 300px; | 18 height: 300px; |
| 19 background-color: red; | 19 background-color: red; |
| 20 } | 20 } |
| 21 .item1 { | 21 .item1 { |
| 22 grid-row: 1; | 22 grid-row: 1; |
| 23 grid-column: 1; | 23 grid-column: 1; |
| 24 justify-self: end true; | |
| 24 background-color: green; | 25 background-color: green; |
| 25 border: solid thin blue; | |
|
Julien - ping for review
2015/05/19 17:59:18
Removing the borders is great as it aligns the siz
jfernandez
2015/05/20 20:11:34
Acknowledged.
| |
| 26 width: 150px; | 26 width: 150px; |
| 27 } | 27 } |
| 28 .item2 { | 28 .item2 { |
| 29 grid-row: 1; | 29 grid-row: 1; |
| 30 grid-column: 2; | 30 grid-column: 2; |
| 31 background-color: green; | 31 background-color: green; |
| 32 border: solid thin blue; | 32 justify-self: end true; |
| 33 width: 50px; | 33 width: 50px; |
| 34 </style> | 34 </style> |
| 35 <p style="height: 20px">Tests invalidation on justify-self style change. Passes if there is no red.</p> | 35 <p style="height: 20px">Tests invalidation on justify-self style change. Passes if there is no red.</p> |
| 36 <div id="container"> | 36 <div id="container"> |
| 37 <div class="item1"> | 37 <div class="item1"> |
| 38 <div style="height: 150px"></div> | 38 <div style="height: 150px"></div> |
| 39 </div> | 39 </div> |
| 40 <div class="item2"> | 40 <div class="item2"> |
| 41 <div style="height: 100px"></div> | 41 <div style="height: 100px"></div> |
| 42 </div> | 42 </div> |
| 43 </div> | 43 </div> |
| OLD | NEW |
