LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html - Issue 1130843004: [CSS Grid Layout] New alignment related repaint layout tests.

Side by Side Diff: LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html

Issue 1130843004: [CSS Grid Layout] New alignment related repaint layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/repaint/align-content-position-change-grid.html ('K') | « LayoutTests/fast/repaint/align-self-change-grid-expected.txt ('k') | LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid-expected.txt » ('j') | LayoutTests/fast/repaint/justify-items-overflow-change.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="resources/text-based-repaint.js"></script>	2 <script src="resources/text-based-repaint.js"></script>

3 <script>	3 <script>

4 function repaintTest() {	4 function repaintTest() {

5 document.getElementsByClassName('item')[0].style.alignSelf = 'stretch';	5 document.getElementsByClassName('item')[0].style.alignSelf = 'stretch';

6 document.getElementsByClassName('item')[1].style.alignSelf = 'stretch';

7 }	6 }

8 onload = runRepaintTest;	7 onload = runRepaintTest;

9 </script>	8 </script>

10 <style>	9 <style>

11 .flex {	10 body {

12 display: flex;	11 margin: 0;

13 align-items: flex-start;	12 }

	13 #container {

	14 display: grid;

	15 grid: 100px / 300px;

14 width: 200px;	16 width: 200px;

15 height: 300px;	17 height: 300px;

16 background-color: red;	18 background-color: red;

17 }	19 }

18 .item {	20 .item {

	21 grid-row: 1;

	22 grid-column: 1;

	23 align-self: start;

19 background-color: green;	24 background-color: green;

20 border: solid thin blue;

21 width: 100px;

22 height: 300px;

23 }	25 }

24 </style>	26 </style>

25 <p style="height: 20px">There should be no invalidations because align-self styl e change causes no visual change.</p>	27 <p style="height: 20px">There should be no invalidations because align-self styl e change causes no visual change.</p>
	Julien - ping for review 2015/05/19 17:59:17 Usually no invalidation is better done like fast/r Usually no invalidation is better done like fast/repaint/fixed-position-layer-moved.html (checking if there is any repaint rectangle in the output and dumped FAIL in this case). There is one invalidation which means either that we are failing the test (and I prefer an explicit FAIL in this case) or that this description is inaccurate. jfernandez 2015/05/20 20:11:34 I tried with that and there is indeed one invalida Show quoted text On 2015/05/19 17:59:17, Julien Chaffraix - PST wrote: > Usually no invalidation is better done like > fast/repaint/fixed-position-layer-moved.html (checking if there is any repaint > rectangle in the output and dumped FAIL in this case). I tried with that and there is indeed one invalidation rectangle. It s caused by the bug 474798, which it does not affect only align-items and justify-items like it states on its description, but align-self and justify-self properties as well. Show quoted text > > There is one invalidation which means either that we are failing the test (and I > prefer an explicit FAIL in this case) or that this description is inaccurate. I've finally added an entry in the TestExpectations file for this testes, pointing to the mentioned bug, so it will fail while we don't fix it (I'm already working on it).
26 <div class="flex">	28 <div id="container">

27 <div class="item"></div>	29 <div class="item">

28 <div class="item"></div>	30 <div style="height: 300px"></div>

	31 </div>

29 </div>	32 </div>

OLD	NEW