Chromium Code Reviews| Index: fpdfsdk/src/fpdfview.cpp |
| diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp |
| index d9779962326203aa10c45fa194f9741f0da2e67e..637ac96abc2d2fe7712c11eb3da5849c07574e27 100644 |
| --- a/fpdfsdk/src/fpdfview.cpp |
| +++ b/fpdfsdk/src/fpdfview.cpp |
| @@ -825,10 +825,10 @@ DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDestByName(FPDF_DOCUMENT document,FPDF_ |
| return name_tree.LookupNamedDest(pDoc, name); |
| } |
| -DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDest(FPDF_DOCUMENT document, int index, void* buffer, long& buflen) |
| +DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDest(FPDF_DOCUMENT document, int index, void* buffer, long* buflen) |
|
Tom Sepez
2015/05/12 19:22:50
Q: possibly a breaking change.
Lei Zhang
2015/05/12 21:43:03
Ok. Shouldn't be too hard for callers to adapt.
Tom Sepez
2015/05/12 22:36:55
Done.
|
| { |
| if (!buffer) |
| - buflen = 0; |
| + *buflen = 0; |
| if (!document || index < 0) return NULL; |
| CPDF_Document* pDoc = (CPDF_Document*)document; |
| @@ -865,12 +865,12 @@ DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDest(FPDF_DOCUMENT document, int index, |
| CFX_ByteString utf16Name = wsName.UTF16LE_Encode(); |
| unsigned int len = utf16Name.GetLength(); |
| if (!buffer) { |
| - buflen = len; |
| - } else if (buflen >= len) { |
| + *buflen = len; |
| + } else if (*buflen >= len) { |
| memcpy(buffer, utf16Name.c_str(), len); |
| - buflen = len; |
| + *buflen = len; |
| } else { |
| - buflen = -1; |
| + *buflen = -1; |
| } |
| return (FPDF_DEST)pDestObj; |
| } |