Add StoragePartition's ProtocolHandlers at URLRequestContext construction time.

chrome/browser/profiles/profile_impl.h

Index: chrome/browser/profiles/profile_impl.h
diff --git a/chrome/browser/profiles/profile_impl.h b/chrome/browser/profiles/profile_impl.h
index d25fae4dde552707ec686f07d993247f09b91a98..feb52e9348b25f7311a773e310e873a4c6a1ee90 100644
--- a/chrome/browser/profiles/profile_impl.h
+++ b/chrome/browser/profiles/profile_impl.h
@@ -65,11 +65,24 @@ class ProfileImpl : public Profile,
   virtual content::DownloadManagerDelegate*
       GetDownloadManagerDelegate() OVERRIDE;
   virtual net::URLRequestContextGetter* GetRequestContext() OVERRIDE;
+  virtual net::URLRequestContextGetter* CreateRequestContext(

[awong, 2013/01/19 00:43:42]

Both CreateRequestContext() and CreateRequestContextForStoragePartition() are no
longer part of the BorwserContext API.  Move it lower?

Also, this is where it would be good to add the comment explaining the circular
initialization logic + API contract. Namely:
  (1) They create the context returned by the corresponding GetXXX() functions
  (2) They are exposed because of a circular dependency where
GetStoragePartition() is used to retrieve the request context, but creation
still has to happen here so the StoragePartition calls ContextBrowserClient to
call this function.  Also add a link to the bug I have.

[pauljensen, 2013/01/21 06:24:56]

Done. 
I feel like the comment should go in profile.h as this is just an implementation
of that.  Do you agree?  There is already a comment there; I've updated it.

+      scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+          blob_protocol_handler,
+      scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+          file_system_protocol_handler,
+      scoped_ptr<net::URLRequestJobFactory::Interceptor>
+          developer_protocol_handler) OVERRIDE;
   virtual net::URLRequestContextGetter* GetRequestContextForRenderProcess(
       int renderer_child_id) OVERRIDE;
-  virtual net::URLRequestContextGetter* GetRequestContextForStoragePartition(
+  virtual net::URLRequestContextGetter* CreateRequestContextForStoragePartition(
       const FilePath& partition_path,
-      bool in_memory) OVERRIDE;
+      bool in_memory,
+      scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+          blob_protocol_handler,
+      scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+          file_system_protocol_handler,
+      scoped_ptr<net::URLRequestJobFactory::Interceptor>
+          developer_protocol_handler) OVERRIDE;
   virtual net::URLRequestContextGetter* GetMediaRequestContext() OVERRIDE;
   virtual net::URLRequestContextGetter* GetMediaRequestContextForRenderProcess(
       int renderer_child_id) OVERRIDE;