chrome/browser/profiles/off_the_record_profile_impl.h - Issue 11308362: Add StoragePartition's ProtocolHandlers at URLRequestContext construction time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/off_the_record_profile_impl.h

Issue 11308362: Add StoragePartition's ProtocolHandlers at URLRequestContext construction time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Avoid DCHECK in GetExtensionInfoMap() during Init() Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/chrome_url_request_context.cc ('k') | chrome/browser/profiles/off_the_record_profile_impl.cc » ('j') | chrome/browser/profiles/off_the_record_profile_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/off_the_record_profile_impl.h

diff --git a/chrome/browser/profiles/off_the_record_profile_impl.h b/chrome/browser/profiles/off_the_record_profile_impl.h

index 87c7095d975d2615418466b5d9fd12d015a048ed..1aaf02d78a218debdd0be5b4f566fc334f465526 100644

--- a/chrome/browser/profiles/off_the_record_profile_impl.h

+++ b/chrome/browser/profiles/off_the_record_profile_impl.h

@@ -50,9 +50,15 @@ class OffTheRecordProfileImpl : public Profile,

virtual PrefService* GetOffTheRecordPrefs() OVERRIDE;

virtual net::URLRequestContextGetter*

GetRequestContextForExtensions() OVERRIDE;

- virtual net::URLRequestContextGetter* GetRequestContextForStoragePartition(

+ virtual net::URLRequestContextGetter* CreateRequestContextForStoragePartition(

const FilePath& partition_path,

- bool in_memory) OVERRIDE;

+ bool in_memory,

+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>

+ blob_protocol_handler,

+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>

+ file_system_protocol_handler,

+ scoped_ptr<net::URLRequestJobFactory::Interceptor>

+ developer_protocol_handler) OVERRIDE;

mmenke 2012/12/20 16:55:06 Declaration order should match profile.h

virtual net::SSLConfigService* GetSSLConfigService() OVERRIDE;

virtual HostContentSettingsMap* GetHostContentSettingsMap() OVERRIDE;

virtual ProtocolHandlerRegistry* GetProtocolHandlerRegistry() OVERRIDE;

@@ -91,6 +97,13 @@ class OffTheRecordProfileImpl : public Profile,

virtual content::DownloadManagerDelegate*

GetDownloadManagerDelegate() OVERRIDE;

virtual net::URLRequestContextGetter* GetRequestContext() OVERRIDE;

+ virtual net::URLRequestContextGetter* CreateRequestContext(

+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>

+ blob_protocol_handler,

+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>

+ file_system_protocol_handler,

+ scoped_ptr<net::URLRequestJobFactory::Interceptor>

+ developer_protocol_handler) OVERRIDE;

mmenke 2012/12/20 16:55:06 This is not part of the BrowserContext. Should go

virtual net::URLRequestContextGetter* GetRequestContextForRenderProcess(

int renderer_child_id) OVERRIDE;

virtual net::URLRequestContextGetter* GetMediaRequestContext() OVERRIDE;