Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: chrome/browser/profiles/off_the_record_profile_impl.cc

Issue 11308362: Add StoragePartition's ProtocolHandlers at URLRequestContext construction time. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync (r179907) Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/off_the_record_profile_impl.cc
diff --git a/chrome/browser/profiles/off_the_record_profile_impl.cc b/chrome/browser/profiles/off_the_record_profile_impl.cc
index af37bd22a94f95daf048e165f2358bc5636d177b..08f65ee699e4312213d746038a116526d6003d4c 100644
--- a/chrome/browser/profiles/off_the_record_profile_impl.cc
+++ b/chrome/browser/profiles/off_the_record_profile_impl.cc
@@ -252,7 +252,25 @@ DownloadManagerDelegate* OffTheRecordProfileImpl::GetDownloadManagerDelegate() {
}
net::URLRequestContextGetter* OffTheRecordProfileImpl::GetRequestContext() {
- return io_data_.GetMainRequestContextGetter();
+ content::StoragePartition* storage_partition =
+ BrowserContext::GetStoragePartition(this, NULL);
awong 2013/02/02 03:26:12 Prefer GetDefaultStoragePartition() to using NULL.
pauljensen 2013/02/04 14:18:54 Please respond to my prior comment on this matter
awong 2013/02/05 02:57:11 Oh sorry. I missed that. Yes, use it. I should mod
+ return storage_partition->GetURLRequestContext();
+}
+
+net::URLRequestContextGetter* OffTheRecordProfileImpl::CreateRequestContext(
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ blob_protocol_handler,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ file_system_protocol_handler,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ developer_protocol_handler,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ chrome_protocol_handler,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ chrome_devtools_protocol_handler) {
+ return io_data_.CreateMainRequestContextGetter(blob_protocol_handler.Pass(),
+ file_system_protocol_handler.Pass(), developer_protocol_handler.Pass(),
+ chrome_protocol_handler.Pass(), chrome_devtools_protocol_handler.Pass());
}
net::URLRequestContextGetter*
@@ -280,7 +298,7 @@ net::URLRequestContextGetter*
OffTheRecordProfileImpl::GetMediaRequestContextForStoragePartition(
const FilePath& partition_path,
bool in_memory) {
- return GetRequestContextForStoragePartition(partition_path, in_memory);
+ return io_data_.GetIsolatedAppRequestContextGetter(partition_path, in_memory);
}
net::URLRequestContextGetter*
@@ -289,10 +307,23 @@ net::URLRequestContextGetter*
}
net::URLRequestContextGetter*
- OffTheRecordProfileImpl::GetRequestContextForStoragePartition(
+ OffTheRecordProfileImpl::CreateRequestContextForStoragePartition(
const FilePath& partition_path,
- bool in_memory) {
- return io_data_.GetIsolatedAppRequestContextGetter(partition_path, in_memory);
+ bool in_memory,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ blob_protocol_handler,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ file_system_protocol_handler,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ developer_protocol_handler,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ chrome_protocol_handler,
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
+ chrome_devtools_protocol_handler) {
+ return io_data_.CreateIsolatedAppRequestContextGetter(
+ partition_path, in_memory, blob_protocol_handler.Pass(),
+ file_system_protocol_handler.Pass(), developer_protocol_handler.Pass(),
+ chrome_protocol_handler.Pass(), chrome_devtools_protocol_handler.Pass());
}
content::ResourceContext* OffTheRecordProfileImpl::GetResourceContext() {

Powered by Google App Engine
This is Rietveld 408576698