Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11308332: Fix Graphics2D in NaCl. (Closed)

Created:
8 years ago by brettw
Modified:
8 years ago
Reviewers:
bbudge
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix Graphics2D in NaCl. This makes Graphics2D resource creation no longer under the "dev" flag. It also makes binding a graphics context non-synchronous. It doesn't need to be synchronous other than returning success/failure, which almost nobody will check anyway, and most success/failure cases we can detect in the proxy anyway. Doing this prevents the synchronous bind from racing with the async creation in the nested-message-loop case which can run sync messages out-of-order. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170841

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M content/renderer/pepper/content_renderer_pepper_host_factory.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 4 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
8 years ago (2012-12-03 21:12:05 UTC) #1
bbudge
8 years ago (2012-12-03 21:16:54 UTC) #2
LGTM with a comment

https://codereview.chromium.org/11308332/diff/1/ppapi/proxy/ppb_instance_prox...
File ppapi/proxy/ppb_instance_proxy.cc (right):

https://codereview.chromium.org/11308332/diff/1/ppapi/proxy/ppb_instance_prox...
ppapi/proxy/ppb_instance_proxy.cc:815: enter.functions()->BindGraphics(instance,
device);
Maybe a comment that we're discarding the return value here, and why that's OK.

Powered by Google App Engine
This is Rietveld 408576698