Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1130833005: Merge gesture deletion and selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 const Experiment::Choice kGestureTypingChoices[] = { 480 const Experiment::Choice kGestureTypingChoices[] = {
481 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 481 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
482 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 482 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
483 keyboard::switches::kGestureTyping, 483 keyboard::switches::kGestureTyping,
484 keyboard::switches::kGestureTypingDisabled}, 484 keyboard::switches::kGestureTypingDisabled},
485 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 485 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
486 keyboard::switches::kGestureTyping, 486 keyboard::switches::kGestureTyping,
487 keyboard::switches::kGestureTypingEnabled}, 487 keyboard::switches::kGestureTypingEnabled},
488 }; 488 };
489 489
490 const Experiment::Choice kGestureSelectionChoices[] = { 490 const Experiment::Choice kGestureEditingChoices[] = {
491 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 491 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
492 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 492 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
493 keyboard::switches::kGestureSelection, 493 keyboard::switches::kGestureEditing,
494 keyboard::switches::kGestureSelectionDisabled}, 494 keyboard::switches::kGestureEditingDisabled},
495 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 495 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
496 keyboard::switches::kGestureSelection, 496 keyboard::switches::kGestureEditing,
497 keyboard::switches::kGestureSelectionEnabled}, 497 keyboard::switches::kGestureEditingEnabled},
498 };
499
500 const Experiment::Choice kGestureDeletionChoices[] = {
501 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
502 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
503 keyboard::switches::kGestureDeletion,
504 keyboard::switches::kGestureDeletionDisabled},
505 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
506 keyboard::switches::kGestureDeletion,
507 keyboard::switches::kGestureDeletionEnabled},
508 }; 498 };
509 #endif 499 #endif
510 500
511 const Experiment::Choice kSupervisedUserSafeSitesChoices[] = { 501 const Experiment::Choice kSupervisedUserSafeSitesChoices[] = {
512 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 502 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
513 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 503 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
514 switches::kSupervisedUserSafeSites, 504 switches::kSupervisedUserSafeSites,
515 "enabled" }, 505 "enabled" },
516 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 506 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
517 switches::kSupervisedUserSafeSites, 507 switches::kSupervisedUserSafeSites,
(...skipping 963 matching lines...) Expand 10 before | Expand all | Expand 10 after
1481 MULTI_VALUE_TYPE(kFloatingVirtualKeyboardChoices) 1471 MULTI_VALUE_TYPE(kFloatingVirtualKeyboardChoices)
1482 }, 1472 },
1483 { 1473 {
1484 "gesture-typing", 1474 "gesture-typing",
1485 IDS_FLAGS_GESTURE_TYPING_NAME, 1475 IDS_FLAGS_GESTURE_TYPING_NAME,
1486 IDS_FLAGS_GESTURE_TYPING_DESCRIPTION, 1476 IDS_FLAGS_GESTURE_TYPING_DESCRIPTION,
1487 kOsCrOS, 1477 kOsCrOS,
1488 MULTI_VALUE_TYPE(kGestureTypingChoices) 1478 MULTI_VALUE_TYPE(kGestureTypingChoices)
1489 }, 1479 },
1490 { 1480 {
1491 "gesture-selection", 1481 "gesture-editing",
1492 IDS_FLAGS_GESTURE_SELECTION_NAME, 1482 IDS_FLAGS_GESTURE_EDITING_NAME,
1493 IDS_FLAGS_GESTURE_SELECTION_DESCRIPTION, 1483 IDS_FLAGS_GESTURE_EDITING_DESCRIPTION,
1494 kOsCrOS, 1484 kOsCrOS,
1495 MULTI_VALUE_TYPE(kGestureSelectionChoices) 1485 MULTI_VALUE_TYPE(kGestureEditingChoices)
1496 },
1497 {
1498 "gesture-deletion",
1499 IDS_FLAGS_GESTURE_DELETION_NAME,
1500 IDS_FLAGS_GESTURE_DELETION_DESCRIPTION,
1501 kOsCrOS,
1502 MULTI_VALUE_TYPE(kGestureDeletionChoices)
1503 }, 1486 },
1504 { 1487 {
1505 "disable-smart-virtual-keyboard", 1488 "disable-smart-virtual-keyboard",
1506 IDS_FLAGS_DISABLE_SMART_VIRTUAL_KEYBOARD_NAME, 1489 IDS_FLAGS_DISABLE_SMART_VIRTUAL_KEYBOARD_NAME,
1507 IDS_FLAGS_DISABLE_SMART_VIRTUAL_KEYBOARD_DESCRIPTION, 1490 IDS_FLAGS_DISABLE_SMART_VIRTUAL_KEYBOARD_DESCRIPTION,
1508 kOsCrOS, 1491 kOsCrOS,
1509 SINGLE_VALUE_TYPE(keyboard::switches::kDisableSmartVirtualKeyboard) 1492 SINGLE_VALUE_TYPE(keyboard::switches::kDisableSmartVirtualKeyboard)
1510 }, 1493 },
1511 #endif 1494 #endif
1512 { 1495 {
(...skipping 1544 matching lines...) Expand 10 before | Expand all | Expand 10 after
3057 } 3040 }
3058 3041
3059 const Experiment* GetExperiments(size_t* count) { 3042 const Experiment* GetExperiments(size_t* count) {
3060 *count = num_experiments; 3043 *count = num_experiments;
3061 return experiments; 3044 return experiments;
3062 } 3045 }
3063 3046
3064 } // namespace testing 3047 } // namespace testing
3065 3048
3066 } // namespace about_flags 3049 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698