Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ui/base/events/event_dispatcher.h

Issue 11308322: events: Start changing EventHandler interface to not return a value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/events/event.cc ('k') | ui/base/events/event_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/events/event_dispatcher.h
diff --git a/ui/base/events/event_dispatcher.h b/ui/base/events/event_dispatcher.h
index 4177848107be088bd419cec4c21b438984d338ec..e179c672d19bf2a6618e5d36b420990b86a95bab 100644
--- a/ui/base/events/event_dispatcher.h
+++ b/ui/base/events/event_dispatcher.h
@@ -24,9 +24,9 @@ class UI_EXPORT EventDispatcher {
virtual bool CanDispatchToTarget(EventTarget* target) = 0;
template<class T>
- int ProcessEvent(EventTarget* target, T* event) {
+ void ProcessEvent(EventTarget* target, T* event) {
if (!target || !target->CanAcceptEvents())
- return ER_UNHANDLED;
+ return;
ScopedDispatchHelper dispatch_helper(event);
dispatch_helper.set_target(target);
@@ -34,9 +34,9 @@ class UI_EXPORT EventDispatcher {
EventHandlerList list;
target->GetPreTargetHandlers(&list);
dispatch_helper.set_phase(EP_PRETARGET);
- int result = DispatchEventToEventHandlers(list, event);
- if (result & ER_CONSUMED)
- return result;
+ DispatchEventToEventHandlers(list, event);
+ if (event->stopped_propagation())
+ return;
// If the event hasn't been consumed, trigger the default handler. Note that
// even if the event has already been handled (i.e. return result has
@@ -45,20 +45,18 @@ class UI_EXPORT EventDispatcher {
// abstraction.
if (CanDispatchToTarget(target)) {
dispatch_helper.set_phase(EP_TARGET);
- result |= DispatchEvent(target, event);
- dispatch_helper.set_result(event->result() | result);
- if (result & ER_CONSUMED)
- return result;
+ DispatchEvent(target, event);
+ if (event->stopped_propagation())
+ return;
}
if (!CanDispatchToTarget(target))
- return result;
+ return;
list.clear();
target->GetPostTargetHandlers(&list);
dispatch_helper.set_phase(EP_POSTTARGET);
- result |= DispatchEventToEventHandlers(list, event);
- return result;
+ DispatchEventToEventHandlers(list, event);
}
const Event* current_event() const { return current_event_; }
@@ -75,27 +73,25 @@ class UI_EXPORT EventDispatcher {
};
template<class T>
- int DispatchEventToEventHandlers(EventHandlerList& list, T* event) {
- int result = ER_UNHANDLED;
- Event::DispatcherApi dispatch_helper(event);
+ void DispatchEventToEventHandlers(EventHandlerList& list, T* event) {
for (EventHandlerList::const_iterator it = list.begin(),
end = list.end(); it != end; ++it) {
- result |= DispatchEvent((*it), event);
- dispatch_helper.set_result(event->result() | result);
- if (result & ER_CONSUMED)
- return result;
+ DispatchEvent((*it), event);
+ if (event->stopped_propagation())
+ return;
}
- return result;
}
// Dispatches an event, and makes sure it sets ER_CONSUMED on the
// event-handling result if the dispatcher itself has been destroyed during
// dispatching the event to the event handler.
template<class T>
- int DispatchEvent(EventHandler* handler, T* event) {
+ void DispatchEvent(EventHandler* handler, T* event) {
// If the target has been invalidated or deleted, don't dispatch the event.
- if (!CanDispatchToTarget(event->target()))
- return ui::ER_CONSUMED;
+ if (!CanDispatchToTarget(event->target())) {
+ event->StopPropagation();
+ return;
+ }
bool destroyed = false;
set_on_destroy_ = &destroyed;
@@ -104,17 +100,16 @@ class UI_EXPORT EventDispatcher {
// cause invalid memory-write when AutoReset tries to restore the value.
Event* old_event = current_event_;
current_event_ = event;
- int result = DispatchEventToSingleHandler(handler, event);
+ DispatchEventToSingleHandler(handler, event);
if (destroyed) {
- result |= ui::ER_CONSUMED;
+ event->StopPropagation();
} else {
current_event_ = old_event;
set_on_destroy_ = NULL;
}
- return result;
}
- EventResult DispatchEventToSingleHandler(EventHandler* handler, Event* event);
+ void DispatchEventToSingleHandler(EventHandler* handler, Event* event);
// This is used to track whether the dispatcher has been destroyed in the
// middle of dispatching an event.
« no previous file with comments | « ui/base/events/event.cc ('k') | ui/base/events/event_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698