google_apis: Add a test for uploading a large file

google_apis: Add a test for uploading a large file

An upload of a large file requires multiple requests of ResumeUploadOperation
which should be tested.

BUG=162348
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170707

[kinaba, 2012-12-03 04:37:57]

https://codereview.chromium.org/11308315/diff/1/chrome/browser/google_apis/gd...
File chrome/browser/google_apis/gdata_wapi_operations_unittest.cc (right):

https://codereview.chromium.org/11308315/diff/1/chrome/browser/google_apis/gd...
chrome/browser/google_apis/gdata_wapi_operations_unittest.cc:1057:
EXPECT_EQ(HTTP_SUCCESS, response.code);
The expected response code for UPLOAD_NEW_FILE mode is HTTP_CREATED, not
HTTP_SUCCESS. We may want to exercise the difference in the tests here, because
both the internals of ResumeUploadOperation and the client DriveUploader code
are distinguishing them.
 (Sorry I should have noticed this in the previous patch :(.)

[satorux1, 2012-12-03 05:02:22]

https://codereview.chromium.org/11308315/diff/1/chrome/browser/google_apis/gd...
File chrome/browser/google_apis/gdata_wapi_operations_unittest.cc (right):

https://codereview.chromium.org/11308315/diff/1/chrome/browser/google_apis/gd...
chrome/browser/google_apis/gdata_wapi_operations_unittest.cc:1057:
EXPECT_EQ(HTTP_SUCCESS, response.code);
On 2012/12/03 04:37:57, kinaba wrote:
> The expected response code for UPLOAD_NEW_FILE mode is HTTP_CREATED, not
> HTTP_SUCCESS. We may want to exercise the difference in the tests here,
because
> both the internals of ResumeUploadOperation and the client DriveUploader code
> are distinguishing them.
>  (Sorry I should have noticed this in the previous patch :(.)

Good catch! Fixed!

[kinaba, 2012-12-03 06:17:21]

lgtm