Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11308293: Fix test.dart's --build-directory option to accept absolute paths. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 841c13a79add11cd43a3fb1ead077726918bf917..ad7e9f49663d6b11bbd603b1e9dc6f65dbe75382 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1028,15 +1028,14 @@ class StandardTestSuite extends TestSuite {
var minified = configuration['minified'] ? '-minified' : '';
var dirName = "${configuration['compiler']}-${configuration['runtime']}"
"$checked$minified";
- var generatedTestPath = Strings.join([
- buildDir,
- 'generated_tests',
- dirName,
- testUniqueName
- ], '/');
-
- TestUtils.mkdirRecursive(new Path('.'), new Path(generatedTestPath));
- return new File(generatedTestPath).fullPathSync().replaceAll('\\', '/');
+ Path generatedTestPath = new Path.fromNative(buildDir)
ahe 2012/12/03 11:42:39 Nice.
+ .append('generated_tests')
+ .append(dirName)
+ .append(testUniqueName);
+
+ TestUtils.mkdirRecursive(new Path('.'), generatedTestPath);
+ return new File.fromPath(generatedTestPath).fullPathSync()
+ .replaceAll('\\', '/');
}
String get scriptType {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698