Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 11308261: base: Use TEST() macro when possible. (Closed)

Created:
8 years ago by tfarina
Modified:
8 years ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, jshin+watch_chromium.org
Visibility:
Public.

Description

base: Use TEST() macro when possible. There is no need to inherit from testing::Test and then have to use TEST_F(), if you aren't overridding SetUp() or TearDow(). So if you don't need to customize it, you can use TEST() macro directly and it does that for us automagically. Fix all the cases found with the following command line: $ git grep -n1 "public testing::Test" base/ | grep "};" TEST=base_unittests R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170747

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -44 lines) Patch
M base/file_version_info_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M base/id_map_unittest.cc View 10 chunks +10 lines, -12 lines 0 comments Download
M base/message_loop_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/prefs/pref_value_map_unittest.cc View 1 6 chunks +7 lines, -9 lines 0 comments Download
M base/string_tokenizer_unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M base/version_unittest.cc View 1 2 6 chunks +10 lines, -9 lines 0 comments Download
M base/vlog_unittest.cc View 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
8 years ago (2012-11-28 23:43:44 UTC) #1
tfarina
Hi Mark, could you check if this is OK? Thank you,
8 years ago (2012-11-29 20:32:12 UTC) #2
tfarina
fiendly ping? Brett, if you can, could you take a look at this? Thank you!
8 years ago (2012-11-30 23:52:48 UTC) #3
willchan no longer on Chromium
lgtm
8 years ago (2012-12-02 23:14:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11308261/4001
8 years ago (2012-12-02 23:14:19 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-03 01:03:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11308261/4001
8 years ago (2012-12-03 14:10:56 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) ash_unittests
8 years ago (2012-12-03 15:59:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11308261/4001
8 years ago (2012-12-03 16:01:02 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-03 16:42:40 UTC) #10
Retried try job too often on linux_rel for step(s) ash_unittests

Powered by Google App Engine
This is Rietveld 408576698