sdk/lib/_internal/compiler/implementation/lib/js_string.dart - Issue 11308257: - Parse the return type of JS during resolution to know what can be instantiated there.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_string.dart

Issue 11308257: - Parse the return type of JS during resolution to know what can be instantiated there. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/enqueue.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/js_string.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/lib/js_string.dart (revision 15445)

+++ sdk/lib/_internal/compiler/implementation/lib/js_string.dart (working copy)

@@ -50,17 +50,17 @@

List<String> split(Pattern pattern) {

checkNull(pattern);

if (pattern is String) {

- return JS('JSArray', r'#.split(#)', this, pattern);

+ return JS('=List', r'#.split(#)', this, pattern);

} else if (pattern is JSSyntaxRegExp) {

var re = regExpGetNative(pattern);

- return JS('JSArray', r'#.split(#)', this, re);

+ return JS('=List', r'#.split(#)', this, re);

} else {

throw "String.split(Pattern) UNIMPLEMENTED";

}

List<String> splitChars() {

- return JS('JSArray', r'#.split("")', this);

+ return JS('=List', r'#.split("")', this);

}

bool startsWith(String other) {