- Parse the return type of JS during resolution to know what can be instantiated there.

sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 typedef void Recompile(Element element);
 
 class ReturnInfo {
   HType returnType;
@@ skipping 743 matching lines @@
   }
 
   void initializeInterceptorElements() {
     objectInterceptorClass =
         compiler.findInterceptor(const SourceString('ObjectInterceptor'));
     getInterceptorMethod =
         compiler.findInterceptor(const SourceString('getInterceptor'));
     List<ClassElement> classes = [
       jsStringClass = compiler.findInterceptor(const SourceString('JSString')),
       jsArrayClass = compiler.findInterceptor(const SourceString('JSArray')),
-      jsNumberClass = compiler.findInterceptor(const SourceString('JSNumber')),
+      // The int class must be before the double class, because the
+      // emitter relies on this list for the order of type checks.
       jsIntClass = compiler.findInterceptor(const SourceString('JSInt')),
       jsDoubleClass = compiler.findInterceptor(const SourceString('JSDouble')),
+      jsNumberClass = compiler.findInterceptor(const SourceString('JSNumber')),
       jsNullClass = compiler.findInterceptor(const SourceString('JSNull')),
       jsFunctionClass =
           compiler.findInterceptor(const SourceString('JSFunction')),
       jsBoolClass = compiler.findInterceptor(const SourceString('JSBool'))];
 
     jsArrayClass.ensureResolved(compiler);
     jsArrayLength =
         jsArrayClass.lookupLocalMember(const SourceString('length'));
 
     jsStringClass.ensureResolved(compiler);
     jsStringLength =
         jsStringClass.lookupLocalMember(const SourceString('length'));
 
     for (ClassElement cls in classes) {
       if (cls != null) interceptedClasses[cls] = null;
     }
   }
 
-  void addInterceptors(ClassElement cls) {
-    cls.ensureResolved(compiler);
-    cls.forEachMember((ClassElement classElement, Element member) {
-        Set<Element> set = interceptedElements.putIfAbsent(
-            member.name, () => new Set<Element>());
-        set.add(member);
-      },
-      includeSuperMembers: true);
+  void addInterceptors(ClassElement cls, Enqueuer enqueuer) {
+    if (enqueuer.isResolutionQueue) {
+      cls.ensureResolved(compiler);
+      cls.forEachMember((ClassElement classElement, Element member) {
+          Set<Element> set = interceptedElements.putIfAbsent(
+              member.name, () => new Set<Element>());
+          set.add(member);
+        },
+        includeSuperMembers: true);
+    }
+    enqueuer.registerInstantiatedClass(cls);
   }
 
   String registerSpecializedGetInterceptor(Set<ClassElement> classes) {
     compiler.enqueuer.codegen.registerInstantiatedClass(objectInterceptorClass);
     if (classes.contains(compiler.objectClass)) {
       // We can't use a specialized [getInterceptorMethod], so we make
       // sure we emit the one with all checks.
       String name = namer.getName(getInterceptorMethod);
       specializedGetInterceptors.putIfAbsent(name, () {
-        // It is important to take the order provided by this list,
+        // It is important to take the order provided by the map,
         // because we want the int type check to happen before the
         // double type check: the double type check covers the int
-        // type check.
-        return interceptedClasses.keys;
+        // type check. Also we don't need to do a number type check
+        // because that is covered by the double type check.
+        List<ClassElement> keys = <ClassElement>[];
+        interceptedClasses.forEach((ClassElement cls, _) {
+          if (cls != jsNumberClass) keys.add(cls);
+        });
+        return keys;
       });
       return namer.isolateAccess(getInterceptorMethod);
     } else {
       String name = namer.getSpecializedName(getInterceptorMethod, classes);
       specializedGetInterceptors[name] = classes;
       return '${namer.CURRENT_ISOLATE}.$name';
     }
   }
 
   void registerInstantiatedClass(ClassElement cls, Enqueuer enqueuer) {
     ClassElement result = null;
     if (!_interceptorsAreInitialized) {
       initializeInterceptorElements();
       _interceptorsAreInitialized = true;
     }
     if (cls == compiler.stringClass) {
-      result = jsStringClass;
+      addInterceptors(jsStringClass, enqueuer);
     } else if (cls == compiler.listClass) {
-      result = jsArrayClass;
+      addInterceptors(jsArrayClass, enqueuer);
     } else if (cls == compiler.intClass) {
-      result = jsIntClass;
-      enqueuer.registerInstantiatedClass(jsNumberClass);
+      addInterceptors(jsIntClass, enqueuer);
+      addInterceptors(jsNumberClass, enqueuer);
     } else if (cls == compiler.doubleClass) {
-      result = jsDoubleClass;
-      enqueuer.registerInstantiatedClass(jsNumberClass);
+      addInterceptors(jsDoubleClass, enqueuer);
+      addInterceptors(jsNumberClass, enqueuer);
     } else if (cls == compiler.functionClass) {
-      result = jsFunctionClass;
+      addInterceptors(jsFunctionClass, enqueuer);
     } else if (cls == compiler.boolClass) {
-      result = jsBoolClass;
+      addInterceptors(jsBoolClass, enqueuer);
     } else if (cls == compiler.nullClass) {
-      result = jsNullClass;
+      addInterceptors(jsNullClass, enqueuer);
+    } else if (cls == compiler.numClass) {
+      addInterceptors(jsIntClass, enqueuer);
+      addInterceptors(jsDoubleClass, enqueuer);
+      addInterceptors(jsNumberClass, enqueuer);
     }
-
-    if (result == null) return;
-    if (enqueuer.isResolutionQueue) addInterceptors(result);
-    enqueuer.registerInstantiatedClass(result);
   }
 
   Element get cyclicThrowHelper {
     return compiler.findHelper(const SourceString("throwCyclicInit"));
   }
 
   JavaScriptItemCompilationContext createItemCompilationContext() {
     return new JavaScriptItemCompilationContext();
   }
 
@@ skipping 251 matching lines @@
     print("Inferred return types:");
     print("----------------------");
     dumpReturnTypes();
     print("");
     print("Inferred field types:");
     print("------------------------");
     fieldTypes.dump();
     print("");
   }
 }