Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 11308248: Merge 135809 - [Chromium] Shared graphics context should only pushGroupMarker() once (Closed)

Created:
8 years ago by Stephen White
Modified:
8 years ago
Reviewers:
Stephen White
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 135809 - [Chromium] Shared graphics context should only pushGroupMarker() once https://bugs.webkit.org/show_bug.cgi?id=103082 Reviewed by James Robinson. GraphicsContext3D's pushGroupMarkerEXT() is being called every time an ImageBuffer is created, leading to unlimited memory growth, since they share a common GraphicsContext3D. It should be called only once, on context creation. See also http://crbug.com/160411. Tested by manually checking the memory usage in Chrome's TaskManager. (Sorry, I can't think of a way to test this automatically.) * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3DImpl::getOrCreateContext): * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::createAcceleratedCanvas): TBR=senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Stephen White
8 years ago (2012-11-28 18:19:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698