Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1130823005: win: Transform \ to / in blink plugin. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
sof
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Transform \ to / in blink plugin. ignored_directories assumes that the path separator is /. (https://codereview.chromium.org/1072203002 did the same change for the style plugin.) BUG=486571 Committed: https://crrev.com/3da0afe08ecde7c1292c4bfce774b86c3cfd14a3 Cr-Commit-Position: refs/heads/master@{#330310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 7 months ago (2015-05-17 17:08:52 UTC) #2
sof
lgtm
5 years, 7 months ago (2015-05-17 17:17:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130823005/1
5 years, 7 months ago (2015-05-17 17:44:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-17 17:51:54 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:32:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3da0afe08ecde7c1292c4bfce774b86c3cfd14a3
Cr-Commit-Position: refs/heads/master@{#330310}

Powered by Google App Engine
This is Rietveld 408576698