Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1130823004: Roll DOM Distiller JavaScript distribution package (Closed)

Created:
5 years, 7 months ago by wychen
Modified:
5 years, 7 months ago
Reviewers:
nyquist, kuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/e3ef0c4c8e...aa79b394e7 Picked up changes: aa79b39 Strip bgcolor attribute from all table elements ec27418 Show distilled page in Chrome Extension 1f211a4 Simplify testImageWithSrcset b9e2b72 Update doc about Developing on Mac OS X 270058c Shuffle tests in continuous integration f5070fd Properly restore test environment between tests 7a0544c Support running jstests repeatedly fa4d011 Support running tests in random order a03cbd2 Disregard "comment" appearing in className when too many classes 0650d41 Never regard HTML elements as comments 31359c2 Allow test.filter to begin with a dash d4854eb Catch errors in continuous integration script 8a6e619 Skip tests using URL() in continuous integration af015b9 Update document about filter syntax in jstest b27ab2b Replace create_standalone_js.py with a custom GWT linker 10bc28c implement validations of pagination URLs 1ec32c2 Strip color attributes from font tags 772dbda Add script for landing CLs on behalf of external authors. c0edaeb Find Python using 'env' in protoc plugin 9ae05a4 Fix regression in srcset handling BUG=382993, 436226, 437113, 464123, 483036, 483149, 483172 Committed: https://crrev.com/9141c233fc54e713cee08c4c5ee79cb71fb7ee94 Cr-Commit-Position: refs/heads/master@{#329993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/LICENSE View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
wychen
PTAL
5 years, 7 months ago (2015-05-14 22:44:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130823004/1
5 years, 7 months ago (2015-05-14 22:45:02 UTC) #4
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 7 months ago (2015-05-14 22:45:05 UTC) #6
wychen
I've manually changed the bug id from 464143 to 464123. Ref: https://code.google.com/p/chromium/issues/detail?id=464123 https://codereview.chromium.org/1029593003
5 years, 7 months ago (2015-05-14 22:50:08 UTC) #8
kuan
thanks, wei-yin! lgtm.
5 years, 7 months ago (2015-05-14 22:51:53 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130823004/1
5 years, 7 months ago (2015-05-14 22:55:13 UTC) #11
nyquist
lgtm
5 years, 7 months ago (2015-05-14 23:56:59 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 00:08:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130823004/1
5 years, 7 months ago (2015-05-15 00:20:21 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 00:25:42 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 00:26:34 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9141c233fc54e713cee08c4c5ee79cb71fb7ee94
Cr-Commit-Position: refs/heads/master@{#329993}

Powered by Google App Engine
This is Rietveld 408576698