Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1130823003: Wait for display configuration to finish before suspending (Closed)

Created:
5 years, 7 months ago by dnicoara
Modified:
5 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, oshima+watch_chromium.org, derat+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait for display configuration to finish before suspending If the suspend doesn't wait, the display configuration query will race with the suspend call. It may be possible to suspend before the configuration query finishes. That would mean that we'd be reading display configuration at resume. BUG=477433 Committed: https://crrev.com/9ae8bbc5b1b185a43ddc4b3f1cf82afc9f325bd8 Cr-Commit-Position: refs/heads/master@{#328612}

Patch Set 1 #

Patch Set 2 : unittests #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M ash/system/chromeos/power/power_event_observer.cc View 2 chunks +9 lines, -1 line 0 comments Download
M ui/display/chromeos/display_configurator.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 1 6 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dnicoara
5 years, 7 months ago (2015-05-06 19:06:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130823003/20001
5 years, 7 months ago (2015-05-06 19:19:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 19:50:15 UTC) #6
oshima
lgtm with a nit https://codereview.chromium.org/1130823003/diff/20001/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/1130823003/diff/20001/ui/display/chromeos/display_configurator.h#newcode227 ui/display/chromeos/display_configurator.h:227: // machines where display configuration ...
5 years, 7 months ago (2015-05-06 20:25:21 UTC) #7
dnicoara
https://codereview.chromium.org/1130823003/diff/20001/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/1130823003/diff/20001/ui/display/chromeos/display_configurator.h#newcode227 ui/display/chromeos/display_configurator.h:227: // machines where display configuration is slow. On 2015/05/06 ...
5 years, 7 months ago (2015-05-06 20:28:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130823003/40001
5 years, 7 months ago (2015-05-06 20:30:03 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-06 21:07:04 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 21:08:01 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9ae8bbc5b1b185a43ddc4b3f1cf82afc9f325bd8
Cr-Commit-Position: refs/heads/master@{#328612}

Powered by Google App Engine
This is Rietveld 408576698