Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: build/common.gypi

Issue 11308229: Revert 169592: Now that the libvpx roll is in, this should work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 169668)
+++ build/common.gypi (working copy)
@@ -2700,13 +2700,12 @@
'target_conditions': [
['_toolset=="target"', {
'cflags': [
- '-faddress-sanitizer',
+ '-fsanitize=address',
'-fno-omit-frame-pointer',
- # See http://crbug.com/159580
- '-w',
+ '-w', # http://crbug.com/162783
],
'ldflags': [
- '-faddress-sanitizer',
+ '-fsanitize=address',
],
'defines': [
'ADDRESS_SANITIZER',
@@ -3164,9 +3163,8 @@
# Due to issues in Clang build system, using ASan on 32-bit
# binaries on x86_64 host is problematic.
# TODO(eugenis): re-enable.
- '-faddress-sanitizer',
- # See http://crbug.com/159580
- '-w',
+ '-fsanitize=address',
+ '-w', # http://crbug.com/162783
],
'ldflags!': [
'-faddress-sanitizer',
@@ -3287,9 +3285,8 @@
['asan==1', {
'xcode_settings': {
'OTHER_CFLAGS': [
- '-faddress-sanitizer',
- # See http://crbug.com/159580
- '-w',
+ '-fsanitize=address',
+ '-w', # http://crbug.com/162783
],
},
'defines': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698