Issue 11308217: Add empty default for test_data flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308217: Add empty default for test_data flag. (Closed)

Created:
8 years ago by Yaron

Modified:
8 years ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach, aberent

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add empty default for test_data flag. This fixes the issue where some test suites don't have additional data to push. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169551

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/android/pylib/test_options_parser.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yaron

Caused by: https://chromiumcodereview.appspot.com/11348202/ We were seeing errors of the form: TypeError: 'NoneType' object is not ...

8 years ago (2012-11-27 01:10:02 UTC) #1

commit-bot: I haz the power

8 years ago (2012-11-27 01:17:07 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11308217/1

Expand Messages | Collapse Messages