Emit constants using ASTs

sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Index: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
index 691d73babc3d4a780a6ab4cddbff5339d7e1a17c..51543b2d57874bbd1dd0d9497cc1283045bd1994 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
@@ -408,8 +408,12 @@ class Namer {
     return "$ISOLATE.$ISOLATE_PROPERTIES.${getName(element)}";
   }
 
-  String isolatePropertiesAccessForConstant(String constantName) {
-    return "$ISOLATE.$ISOLATE_PROPERTIES.$constantName";
+  js.Expression isolatePropertiesAccessForConstant(String constantName) {

[ngeoffray, 2012/11/27 09:26:28]

I'd prefer not having this method here. The namer is pretty consistent in
returning strings.

[sra1, 2012/11/28 03:59:44]

I might agree, but that leaves the question of where to put this method?
In this case I will fold it into ConstantReferenceEmitter.

isolateAccess will need to be converted to return an expression too, but it is
called from 25 places in 6 files.  Better to have one place that knows how to
'index' the current isolate than 25.  Consider what happens if we wrap the code
in a function - 25 places to update expression from an access path to a simple
local variable.

[ngeoffray, 2012/11/28 09:25:21]

So maybe the isolateAccess, isolateBailoutAccess... methods that do property
access on the isolate should really not be in the namer. We should get a js.Ast
builder class that helps for doing these operations.

[floitsch, 2012/11/28 10:04:32]

I agree. And it should probably be the emitter anyways that should give that
information.

+    //  $ISOLATE.$ISOLATE_PROPERTIES.$constantName
+    return new js.PropertyAccess.field(
+        new js.PropertyAccess.field(
+            new js.VariableUse(ISOLATE), ISOLATE_PROPERTIES),
+        constantName);
   }
 
   String isolateAccess(Element element) {