Deal with extension loading from packages.

runtime/bin/extensions.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/extensions.h"
 
 #include <stdio.h>
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/globals.h"
 #include "bin/dartutils.h"
 #include "bin/file.h"
 
 Dart_Handle Extensions::LoadExtension(const char* extension_url,
                                       Dart_Handle parent_library) {
   char* library_path = strdup(extension_url);
-  if (!library_path || !File::IsAbsolutePath(library_path)) {
-    free(library_path);
-    return Dart_Error("unexpected error in library path");
-  }
+

[Bill Hesse, 2012/11/22 16:18:41]

Do we really want unchecked malloc (strdup) to go ahead to a null pointer error?
 Is that the accepted failure for out of C++ heap memory?

[Mads Ager (google), 2012/11/23 07:07:40]

It would be nicer to deal with it although in general there is little you can do
if a strdup of a short string fails. In that case the next step will probably
fail as well so crashing in a controlled way is usually they best you can do.
I'll restore the null pointer check in this particular case. 

   // Extract the path and the extension name from the url.
   char* last_path_separator = strrchr(library_path, '/');
   char* extension_name = last_path_separator + 1;
   *last_path_separator = '\0';  // Terminate library_path at last separator.
 
   void* library_handle = LoadExtensionLibrary(library_path, extension_name);
   if (!library_handle) {
     free(library_path);
     return Dart_Error("cannot find extension library");
   }
@@ skipping 22 matching lines @@
   }
   char* result = reinterpret_cast<char*>(malloc(size));
   int index = 0;
   for (int i = 0; strings[i] != NULL; i++) {
     index += snprintf(result + index, size - index, "%s", strings[i]);
   }
   ASSERT(index == size - 1);
   ASSERT(result[size - 1] == '\0');
   return result;
 }