Generate native class metadata as a JavaScript AST.

Generate native class metadata as a JavaScript AST.

This allows the metadata to shrink about 15% under --minify.

Committed: https://code.google.com/p/dart/source/detail?r=15236

[floitsch, 2012-11-21 23:51:04]

LGTM!

[ngeoffray, 2012-11-22 08:49:47]

Nice!

https://codereview.chromium.org/11308156/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right):

https://codereview.chromium.org/11308156/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:783: static
List<ArrayElement> _convert(List<Expression> expressions) {
List<ArrayElement> is kind of not true.

[karlklose, 2012-11-22 13:00:08]

I don't think the code works as expected, because you use Strings and
js.Expressions as keys in varDefns.

https://codereview.chromium.org/11308156/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart
(right):

https://codereview.chromium.org/11308156/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:337:
String existing = tagDefns[tag];
exisiting is a js.Expression.

https://codereview.chromium.org/11308156/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:342: if
(varDefns.containsKey(existing)) {
I think that this will never be true, since existing is a js.Expression.