Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1130813002: dart2js cps: Handle error cases. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Whitelist unused API due to semantic visitor being WIP Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart ('k') | pkg/pkg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
index 703885ee072af7ddbcda6f8b6a1853bc39988ad4..3a17fc9a615ef9cdcff81cefd0a1b87d3fe08de6 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
@@ -360,17 +360,7 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
}
String formatArguments(Invoke node) {
- List<String> args = new List<String>();
- int positionalArgumentCount = node.selector.positionalArgumentCount;
- for (int i = 0; i < positionalArgumentCount; ++i) {
- args.add(node.arguments[i].accept(this));
- }
- for (int i = 0; i < node.selector.namedArgumentCount; ++i) {
- String name = node.selector.namedArguments[i];
- String arg = node.arguments[positionalArgumentCount + i].accept(this);
- args.add("$name: $arg");
- }
- return args.join(', ');
+ return node.arguments.map(visitExpression).join(', ');
}
String visitInvokeStatic(InvokeStatic node) {
@@ -535,6 +525,12 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
String visitTypeExpression(TypeExpression node) {
return node.dartType.toString();
}
+
+ @override
+ String visitCreateInvocationMirror(CreateInvocationMirror node) {
+ String args = node.arguments.map(visitExpression).join(', ');
+ return 'CreateInvocationMirror(${node.selector.name}, $args)';
+ }
}
/**
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart ('k') | pkg/pkg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698