dart2js cps: Handle error cases.

pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library tree_ir_tracer;
 
 import 'dart:async' show EventSink;
 import '../tracer.dart';
 import 'tree_ir_nodes.dart';
 
@@ skipping 342 matching lines @@
     return names.varName(node.variable);
   }
 
   String visitAssign(Assign node) {
     String variable = names.varName(node.variable);
     String value = visitExpression(node.value);
     return '$variable = $value';
   }
 
   String formatArguments(Invoke node) {
-    List<String> args = new List<String>();
-    int positionalArgumentCount = node.selector.positionalArgumentCount;
-    for (int i = 0; i < positionalArgumentCount; ++i) {
-      args.add(node.arguments[i].accept(this));
-    }
-    for (int i = 0; i < node.selector.namedArgumentCount; ++i) {
-      String name = node.selector.namedArguments[i];
-      String arg = node.arguments[positionalArgumentCount + i].accept(this);
-      args.add("$name: $arg");
-    }
-    return args.join(', ');
+    return node.arguments.map(visitExpression).join(', ');

[floitsch, 2015/05/08 03:03:40]

why this change?

[asgerf, 2015/05/08 08:17:59]

When targeting JS, the arguments do not agree with the selector. Named arguments
are sorted in the IR builder, and a receiver argument is added for interception.
But the selector stays the same. The end-result was that some arguments would
simply not show up in the IR trace, very confusing.

It would be nice to update the selector to match the arguments, but that won't
work atm. If we updated the selector and codegen registered such a selector as a
dynamic invocation, it would not appear to match the function signatures of the
methods it can actually invoke. In other words, the enqueuer still lives in Dart
land, so we have to remember the original unmodified Dart selector.

   }
 
   String visitInvokeStatic(InvokeStatic node) {
     String head = node.target.name;
     String args = formatArguments(node);
     return "$head($args)";
   }
 
   String visitInvokeMethod(InvokeMethod node) {
     String receiver = node.receiver.accept(this);
@@ skipping 144 matching lines @@
 
   @override
   String visitReifyRuntimeType(ReifyRuntimeType node) {
     return 'Reify ${node.value}';
   }
 
   @override
   String visitTypeExpression(TypeExpression node) {
     return node.dartType.toString();
   }
+
+  @override
+  String visitCreateInvocationMirror(CreateInvocationMirror node) {
+    String args = node.arguments.map(visitExpression).join(', ');
+    return 'CreateInvocationMirror(${node.selector.name}, $args)';
+  }
 }
 
 /**
  * Invents (and remembers) names for Variables that do not have an associated
  * identifier.
  *
  * In case a variable is named v0, v1, etc, it may be assigned a different
  * name to avoid clashing with a previously synthesized variable name.
  */
 class Names {
   final Map<Variable, String> _names = {};
   final Set<String> _usedNames = new Set();
   int _counter = 0;
 
   String varName(Variable v) {
     String name = _names[v];
     if (name == null) {
       String prefix = v.element == null ? 'v' : '${v.element.name}_';
       while (name == null || _usedNames.contains(name)) {
         name = "$prefix${_counter++}";
       }
       _names[v] = name;
       _usedNames.add(name);
     }
     return name;
   }
 }