Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11308124: Hide new Autofill Popup on Main Widget Resize or Move. (Closed)

Created:
8 years, 1 month ago by csharp
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dhollowa+watch_chromium.org, ben+watch_chromium.org, dbeam+watch-autofill_chromium.org, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Hide new Autofill Popup on Main Widget Resize or Move. This will hide the popup when the browser changes size or location. Also add some tests for the WidgetObserver for the function we are observing with. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170458

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merging to OnWidgetBoundsChanged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -13 lines) Patch
M ash/system/tray/tray_background_view.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_view_views.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_view_views.cc View 1 4 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M ui/views/widget/widget_observer.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 6 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
csharp
8 years, 1 month ago (2012-11-20 17:02:22 UTC) #1
sky
https://codereview.chromium.org/11308124/diff/1/ui/views/widget/widget_observer.h File ui/views/widget/widget_observer.h (right): https://codereview.chromium.org/11308124/diff/1/ui/views/widget/widget_observer.h#newcode23 ui/views/widget/widget_observer.h:23: virtual void OnWidgetMoved(Widget* widget) {} Can you combine these ...
8 years, 1 month ago (2012-11-20 19:19:56 UTC) #2
csharp
https://codereview.chromium.org/11308124/diff/1/ui/views/widget/widget_observer.h File ui/views/widget/widget_observer.h (right): https://codereview.chromium.org/11308124/diff/1/ui/views/widget/widget_observer.h#newcode23 ui/views/widget/widget_observer.h:23: virtual void OnWidgetMoved(Widget* widget) {} On 2012/11/20 19:19:56, sky ...
8 years, 1 month ago (2012-11-21 14:53:21 UTC) #3
csharp
ping
8 years ago (2012-11-29 15:30:31 UTC) #4
sky
LGTM
8 years ago (2012-11-29 17:21:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/11308124/5001
8 years ago (2012-11-29 18:56:18 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years ago (2012-11-29 19:22:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/11308124/5001
8 years ago (2012-11-30 15:38:09 UTC) #8
commit-bot: I haz the power
8 years ago (2012-11-30 16:08:27 UTC) #9
Message was sent while issue was closed. 
Change committed as 170458

Powered by Google App Engine
This is Rietveld 408576698