src/runtime.cc - Issue 11308090: Fix sequence point bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 11308090: Fix sequence point bug. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index b16c6855974a59660f07d854677a0fc7a7485beb..8fde642bcc313e717199b70a6835d5378018e8ec 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -1109,7 +1109,8 @@ static MaybeObject* GetOwnProperty(Isolate* isolate,

if (accessors == NULL) {

elms->set(WRITABLE_INDEX, heap->ToBoolean((attrs & READ_ONLY) == 0));

// GetProperty does access check.

- elms->set(VALUE_INDEX, *GetProperty(obj, name));

+ Handle<Object> value = GetProperty(obj, name);

+ elms->set(VALUE_INDEX, *value);

} else {

// Access checks are performed for both accessors separately.

// When they fail, the respective field is not set in the descriptor.

« no previous file with comments | « no previous file | no next file » | no next file with comments »