Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 11308085: Enable fullscreen for apps windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_command_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 93df2cdf7da9b80951e4e48a80041ff9a41a86b1..14bd24b9597f71b520dd655260ea6a48f6bbb740 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -1102,7 +1102,6 @@ void BrowserCommandController::UpdateCommandsForFullscreenMode(
// Disable explicit fullscreen toggling when in metro snap mode.
bool fullscreen_enabled = !browser_->is_type_panel() &&
- !browser_->is_app() &&
fullscreen_mode != FULLSCREEN_METRO_SNAP;
#if defined(OS_MACOSX)
// The Mac implementation doesn't support switching to fullscreen while
@@ -1110,6 +1109,9 @@ void BrowserCommandController::UpdateCommandsForFullscreenMode(
int tabIndex = chrome::IndexOfFirstBlockedTab(browser_->tab_strip_model());
bool has_blocked_tab = tabIndex != browser_->tab_strip_model()->count();
fullscreen_enabled &= !has_blocked_tab;
+#else
scheib 2012/11/19 18:05:49 Document why there is different behavior on Mac.
sail 2012/11/19 18:07:30 I don't know why there's a difference actually :-(
+ // App windows are not allowed to enter fullscreen except on Mac.
+ fullscreen_enabled &= !browser_->is_app();
#endif
command_updater_.UpdateCommandEnabled(IDC_FULLSCREEN, fullscreen_enabled);
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_command_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698