Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Unified Diff: content/browser/web_contents/web_contents_view_aura.h

Issue 11308083: Fix the html select tag showing up at the wrong position. This was a regression from r166446. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix crash Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_aura.h
===================================================================
--- content/browser/web_contents/web_contents_view_aura.h (revision 168290)
+++ content/browser/web_contents/web_contents_view_aura.h (working copy)
@@ -38,6 +38,9 @@
WebContentsViewDelegate* delegate);
private:
+ class WindowObserver;
+ friend class WindowObserver;
sky 2012/11/19 15:04:54 nit: you don't need to friend inner classes. Inner
jam 2012/11/19 18:53:06 Done.
+
virtual ~WebContentsViewAura();
void SizeChangedCommon(const gfx::Size& size);
@@ -122,6 +125,8 @@
scoped_ptr<aura::Window> window_;
+ scoped_ptr<WindowObserver> window_observer_;
+
// The WebContentsImpl whose contents we display.
WebContentsImpl* web_contents_;

Powered by Google App Engine
This is Rietveld 408576698