Fix the html select tag showing up at the wrong position. This was a regression from r166446.

Fix the html select tag showing up at the wrong position. This was a regression from r166446.

The fix is to watch for the top level aura::Window's movement. In Ash, this would be an aura::Window that is the parent of the WebContents. In desktop Aura, this would be the aura::RootWindow. The change watches for this in WebContentsViewAura, similar to how WebContentsViewWin does this with PositionChangedMessageFilter. The reason is that the parent being watched needs to be updated with tab drags, so it's more convenient to do this at WebContentsViewAura's parent, instead of doing it at the RenderWidgetHostViewAura level (since that would need a list of parents).

This change also fixes OnHostMoved not being called on Windows.

In the reland of this patch, I've also fixed WebContentsView implementations holding on to deleted RenderWidgetHostView objects after an interstitial is hidden.

BUG=161174
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168558
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168767

[sky, 2012-11-19 15:04:54]

LGTM

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
File content/browser/web_contents/web_contents_view_aura.cc (right):

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
content/browser/web_contents/web_contents_view_aura.cc:241: : view_(view),
parent_(NULL) {}
nit: each param on its own line.

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
File content/browser/web_contents/web_contents_view_aura.h (right):

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
content/browser/web_contents/web_contents_view_aura.h:42: friend class
WindowObserver;
nit: you don't need to friend inner classes. Inner classes can already use
private methods/members.

[jam, 2012-11-19 18:53:06]

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
File content/browser/web_contents/web_contents_view_aura.cc (right):

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
content/browser/web_contents/web_contents_view_aura.cc:241: : view_(view),
parent_(NULL) {}
On 2012/11/19 15:04:54, sky wrote:
> nit: each param on its own line.

the style guide says it's ok to put them on one line if they all fit:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Constructor_In...

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
File content/browser/web_contents/web_contents_view_aura.h (right):

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
content/browser/web_contents/web_contents_view_aura.h:42: friend class
WindowObserver;
On 2012/11/19 15:04:54, sky wrote:
> nit: you don't need to friend inner classes. Inner classes can already use
> private methods/members.

Done.

[sky, 2012-11-19 22:45:23]

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
File content/browser/web_contents/web_contents_view_aura.cc (right):

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
content/browser/web_contents/web_contents_view_aura.cc:241: : view_(view),
parent_(NULL) {}
On 2012/11/19 18:53:06, John Abd-El-Malek wrote:
> On 2012/11/19 15:04:54, sky wrote:
> > nit: each param on its own line.
> 
> the style guide says it's ok to put them on one line if they all fit:
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Constructor_In...

But this is 2 lines, right? The second example shows what I'm suggesting, and
that example could have fit like you have it here.

[jam, 2012-11-20 01:08:01]

Scott: ptal. I've fixed WebContentsView implementations holding on to deleted
RenderWidgetHostView objects after an interstitial is hidden. See diff between
patchset 4 and 5.

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
File content/browser/web_contents/web_contents_view_aura.cc (right):

https://codereview.chromium.org/11308083/diff/12011/content/browser/web_conte...
content/browser/web_contents/web_contents_view_aura.cc:241: : view_(view),
parent_(NULL) {}
On 2012/11/19 22:45:24, sky wrote:
> On 2012/11/19 18:53:06, John Abd-El-Malek wrote:
> > On 2012/11/19 15:04:54, sky wrote:
> > > nit: each param on its own line.
> > 
> > the style guide says it's ok to put them on one line if they all fit:
> >
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Constructor_In...
> 
> But this is 2 lines, right? The second example shows what I'm suggesting, and
> that example could have fit like you have it here.

ah, I misunderstood that comment to mean that if all the parameters fit on one
line, not everything. but now that you point this out, I realize you're right.
fixed

[sky, 2012-11-20 03:23:23]

LGTM