chrome/browser/resources/chromeos/login/screen_public_account_signin.html - Issue 11308081: cros: Account picker UI for public account.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/login/screen_public_account_signin.html

Issue 11308081: cros: Account picker UI for public account. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased on top of 11419184 Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/chromeos/login/screen_public_account_signin.css ('K') | « chrome/browser/resources/chromeos/login/screen_public_account_signin.css ('k') | chrome/browser/resources/chromeos/login/screen_public_account_signin.js » ('j') | chrome/browser/resources/chromeos/login/screen_public_account_signin.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <div id="public-account-signin" class="step hidden no-logo">

	2 <img id="public-account-avartar">
	bartfab (slow) 2012/11/28 15:11:38 Spelling: It's "avatar", not "avartar" (here and e Spelling: It's "avatar", not "avartar" (here and elsewhere in the CL). xiyuan 2012/12/01 00:24:19 New patch successfully avoided this word. :) Show quoted text On 2012/11/28 15:11:38, bartfab wrote: > Spelling: It's "avatar", not "avartar" (here and elsewhere in the CL). New patch successfully avoided this word. :)
	3 <div id="public-account-avartar-info-divider"></div>

	4 <div id="public-account-info-pane">

	5 <div>

	6 <span id="public-account-name"></span>

	7 <img class="managed-badge"

	8 src="chrome://theme/IDR_CONTROLLED_SETTING_MANDATORY">
	bartfab (slow) 2012/11/28 15:11:38 As was pointed out in the bug, the mock uses the g As was pointed out in the bug, the mock uses the grayscale version of the asset here. xiyuan 2012/12/01 00:24:19 Done. Show quoted text On 2012/11/28 15:11:38, bartfab wrote: > As was pointed out in the bug, the mock uses the grayscale version of the asset > here. Done.
	9 </div>

	10 <div id="public-account-text-contents">

	11 <p id="public-account-info" i18n-content="publicAccountInfo"></p>

	12 <p id="public-account-hint" i18n-content="publicAccountHint"></p>
	bartfab (slow) 2012/11/28 15:11:38 In the grdp file, you called these two "the hint" In the grdp file, you called these two "the hint" and "the bold hint". It would be nice to synchronize the \|id\| attributes with their descriptions in the grdp. How about id="public-account-info" and id="public-account-reminder"? xiyuan 2012/12/01 00:24:19 Done in its new place. Show quoted text On 2012/11/28 15:11:38, bartfab wrote: > In the grdp file, you called these two "the hint" and "the bold hint". It would > be nice to synchronize the \|id\| attributes with their descriptions in the grdp. > How about id="public-account-info" and id="public-account-reminder"? Done in its new place.
	13 </div>

	14 <button id="public-account-enter-button"

	15 i18n-content="publicAccountEnter"></button>

	16 </div>

	17 </div>

OLD	NEW