Include v2 packaged apps in sync.

chrome/browser/sync/test/integration/apps_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/apps_helper.h"
 
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/test/integration/sync_app_helper.h"
@@ skipping 29 matching lines @@
   return true;
 }
 
 std::string InstallApp(Profile* profile, int index) {
   return SyncExtensionHelper::GetInstance()->InstallExtension(
       profile,
       CreateFakeAppName(index),
       extensions::Extension::TYPE_HOSTED_APP);
 }
 
+std::string InstallPlatformApp(Profile* profile, int index) {
+  return SyncExtensionHelper::GetInstance()->InstallExtension(
+      profile,
+      CreateFakeAppName(index),

[akalin, 2012/11/16 18:38:53]

can you add a CreateFakePlatformAppName() function?  Otherwise bad things might
happen if for some reason a fake app and a fake platform app for the same index
are installed.

[Marijn Kruisselbrink, 2012/11/16 18:54:30]

Done.

[Marijn Kruisselbrink, 2012/11/19 18:43:01]

Actually, I decided to undo this again (since this change was what caused the
test to not pass). There are just too many places in apps_helper where it
assumes it can determine the name from just an index (the alternative would be
to have 2 copies of almost every method or pass an extension type to almost
every method).

+      extensions::Extension::TYPE_PLATFORM_APP);
+}
+
 std::string InstallAppForAllProfiles(int index) {
   for (int i = 0; i < test()->num_clients(); ++i)
     InstallApp(test()->GetProfile(i), index);
   return InstallApp(test()->verifier(), index);
 }
 
 void UninstallApp(Profile* profile, int index) {
   return SyncExtensionHelper::GetInstance()->UninstallExtension(
       profile, CreateFakeAppName(index));
 }
@@ skipping 54 matching lines @@
   SetPageOrdinalForApp(destination, index, GetPageOrdinalForApp(source, index));
   SetAppLaunchOrdinalForApp(
       destination, index, GetAppLaunchOrdinalForApp(source, index));
 }
 
 void FixNTPOrdinalCollisions(Profile* profile) {
   SyncAppHelper::GetInstance()->FixNTPOrdinalCollisions(profile);
 }
 
 }  // namespace apps_helper